You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2024/09/04 18:55:36 UTC
[PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
mumrah opened a new pull request, #17094:
URL: https://github.com/apache/kafka/pull/17094
Since 3.9 is our last 3.x release, it is a likely version for users to be on when doing ZK to KRaft migrations. Since we have made many fixes since the initial preview of migrations in 3.4, we should ensure that users cannot start a migration without certain improvements. Specifically, we do not want any users attempting migrations without the support of KIP-868 Metadata Transactions.
This patch prevents the controller from activating if the log is empty, migrations are enabled, and the bootstrap metadata version does not support transactions.
If the log is not empty on startup, as in the case of a software upgrade, we allow the migration to continue where it left off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on code in PR #17094:
URL: https://github.com/apache/kafka/pull/17094#discussion_r1744602613
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -418,7 +418,14 @@ class KafkaServer(
kafkaController.startup()
if (config.migrationEnabled) {
- logger.info("Starting up additional components for ZooKeeper migration")
+ if (config.interBrokerProtocolVersion.isMetadataTransactionSupported) {
+ logger.info("Starting up additional components for ZooKeeper migration")
+ } else {
+ logger.error("Caution! Starting up additional components for ZooKeeper migration without metadata transactions. " +
Review Comment:
Small nit. Can we do the preceding log, but have an additional log at ERROR level saying that we don't support metadata transactions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on code in PR #17094:
URL: https://github.com/apache/kafka/pull/17094#discussion_r1744602613
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -418,7 +418,14 @@ class KafkaServer(
kafkaController.startup()
if (config.migrationEnabled) {
- logger.info("Starting up additional components for ZooKeeper migration")
+ if (config.interBrokerProtocolVersion.isMetadataTransactionSupported) {
+ logger.info("Starting up additional components for ZooKeeper migration")
+ } else {
+ logger.error("Caution! Starting up additional components for ZooKeeper migration without metadata transactions. " +
Review Comment:
Small nit. Can we do the preceding INFO log unconditionally if `config.migrationEnabled`, but have an additional log at ERROR level saying that we don't support metadata transactions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #17094:
URL: https://github.com/apache/kafka/pull/17094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17094:
URL: https://github.com/apache/kafka/pull/17094#issuecomment-2334341332
@cmccabe I think the remaining test failures are unrelated
<img width="1405" alt="image" src="https://github.com/user-attachments/assets/a144b59b-541b-4767-8f29-fcde4f3144b0">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17457 Don't allow ZK migration to start without transactions [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #17094:
URL: https://github.com/apache/kafka/pull/17094#discussion_r1744674417
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -418,7 +418,14 @@ class KafkaServer(
kafkaController.startup()
if (config.migrationEnabled) {
- logger.info("Starting up additional components for ZooKeeper migration")
+ if (config.interBrokerProtocolVersion.isMetadataTransactionSupported) {
+ logger.info("Starting up additional components for ZooKeeper migration")
+ } else {
+ logger.error("Caution! Starting up additional components for ZooKeeper migration without metadata transactions. " +
Review Comment:
Yea, fair enough. I wondered the same. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org