You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tapestry.apache.org by Anatol Pomozov <an...@epam.com> on 2004/02/02 17:43:32 UTC
Re: Fw: DatePicker
Hello Programozás,
It is very simple to create patch file. First of all you need CVS command line client.
For Windoze best port of this great tool AFAIK CvsNT http://www.cvsnt.org/wiki/
Install it and then simply run in command line
cvs -q diff -u -N DatePicker.js >> patch.txt
It creates patch for DatePicker.js
I have created one and if you don't mind I will add it to bugzilla.
To developers: Maybe it is worth to add sections in FAQ like "how to
checkout sources from CVS repository", "how to compile it", "how to create patch
file".
And there is ant task for creating patch file.
<target name="patch" description="Create a patch">
<cvs command="-q diff -u -N" output="patch.txt"/>
</target>
Monday, February 2, 2004, 4:22:37 PM, you wrote:
P> Hi,
P> I don't know how to do the patch so I simply send this to the devlist.
P> Thanks,
P> Norbi
>> >----- Original Message -----
>> >From: <ny...@shaw.ca>
>> >To: "Programozas" <pr...@hotmail.com>
>> >Cc: <ta...@jakarta.apache.org>
>> >Sent: Thursday, January 29, 2004 5:29 PM
>> >Subject: RE: DatePicker
>> >
>> >
>> > > Hi,
>> > >
>> > > I, too, just ran into the positioning issue in Mozilla and discovered
P> its
>> >a bug in the DatePicker javascript
P> (org.apache.tapestry.form.DatePicker.js).
>> >I solved it by copying out DatePicker.* from the source into my own
P> project
>> >and fixing the javascript.
>> > >
>> > > In DatePicker.js in the method
>> > > Calendar.prototype.show(), lines 550 & 551:
>> > > the script sets the position of the component by setting
>> > > <snippet>
>> > > this._calDiv.style.top = p.y + element.offsetHeight + 1;
>> > > this._calDiv.style.left = p.x;
>> > > </snippet>
>> > >
>> > > 2 problems with the above lines: First, Mozilla expects them to be
P> String
>> >types whereas the above are integer types. Second, these CSS properties
P> need
>> >units associated with them such as "px", "pt", "in", "mm", etc. which the
>> >above lines do not include.
>> > >
>> > > TO FIX IT: Add units to the strings:
>> > > <snippet>
>> > > this._calDiv.style.top = (p.y + element.offsetHeight + 1) + "px";
>> > > this._calDiv.style.left = p.x + "px";
>> > > </snippet>
>> > >
>> > > The above fix worked for me and it continues to work in IE as well.
>> > >
>> > > Adam.
P> ---------------------------------------------------------------------
P> To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
P> For additional commands, e-mail:
P> tapestry-dev-help@jakarta.apache.org
--
Best regards,
Anatol mailto:anatol_pomazau@epam.com
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: Fw: DatePicker
Posted by Paul Ferraro <pm...@columbia.edu>.
If you are using Eclipse, it's even easier:
1.) Checkout the latest Tapestry source tree.
2.) Make your changes.
3.) From Package Explorer, right click on the class, choose Team >>
Create Patch
Anatol Pomozov wrote:
>Hello Programozás,
>
>It is very simple to create patch file. First of all you need CVS command line client.
>For Windoze best port of this great tool AFAIK CvsNT http://www.cvsnt.org/wiki/
>Install it and then simply run in command line
>cvs -q diff -u -N DatePicker.js >> patch.txt
>It creates patch for DatePicker.js
>
>I have created one and if you don't mind I will add it to bugzilla.
>
>To developers: Maybe it is worth to add sections in FAQ like "how to
>checkout sources from CVS repository", "how to compile it", "how to create patch
>file".
>
>And there is ant task for creating patch file.
> <target name="patch" description="Create a patch">
> <cvs command="-q diff -u -N" output="patch.txt"/>
> </target>
>
>Monday, February 2, 2004, 4:22:37 PM, you wrote:
>
>P> Hi,
>
>P> I don't know how to do the patch so I simply send this to the devlist.
>
>P> Thanks,
>P> Norbi
>
>
>
>>>>----- Original Message -----
>>>>From: <ny...@shaw.ca>
>>>>To: "Programozas" <pr...@hotmail.com>
>>>>Cc: <ta...@jakarta.apache.org>
>>>>Sent: Thursday, January 29, 2004 5:29 PM
>>>>Subject: RE: DatePicker
>>>>
>>>>
>>>>
>>>>
>>>>>Hi,
>>>>>
>>>>>I, too, just ran into the positioning issue in Mozilla and discovered
>>>>>
>>>>>
>P> its
>
>
>>>>a bug in the DatePicker javascript
>>>>
>>>>
>P> (org.apache.tapestry.form.DatePicker.js).
>
>
>>>>I solved it by copying out DatePicker.* from the source into my own
>>>>
>>>>
>P> project
>
>
>>>>and fixing the javascript.
>>>>
>>>>
>>>>>In DatePicker.js in the method
>>>>>Calendar.prototype.show(), lines 550 & 551:
>>>>>the script sets the position of the component by setting
>>>>><snippet>
>>>>>this._calDiv.style.top = p.y + element.offsetHeight + 1;
>>>>>this._calDiv.style.left = p.x;
>>>>></snippet>
>>>>>
>>>>>2 problems with the above lines: First, Mozilla expects them to be
>>>>>
>>>>>
>P> String
>
>
>>>>types whereas the above are integer types. Second, these CSS properties
>>>>
>>>>
>P> need
>
>
>>>>units associated with them such as "px", "pt", "in", "mm", etc. which the
>>>>above lines do not include.
>>>>
>>>>
>>>>>TO FIX IT: Add units to the strings:
>>>>><snippet>
>>>>>this._calDiv.style.top = (p.y + element.offsetHeight + 1) + "px";
>>>>>this._calDiv.style.left = p.x + "px";
>>>>></snippet>
>>>>>
>>>>>The above fix worked for me and it continues to work in IE as well.
>>>>>
>>>>>Adam.
>>>>>
>>>>>
>
>P> ---------------------------------------------------------------------
>P> To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
>P> For additional commands, e-mail:
>P> tapestry-dev-help@jakarta.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: Fw: DatePicker
Posted by Darren Foltinek <da...@frontrange.ca>.
Hi Anatol,
Sure, if you could patch DatePicker that would be great!
Thanks!
-- Darren
>It is very simple to create patch file. First of all you need CVS command
>line client.
>For Windoze best port of this great tool AFAIK CvsNT
>http://www.cvsnt.org/wiki/
>Install it and then simply run in command line
>cvs -q diff -u -N DatePicker.js >> patch.txt
>It creates patch for DatePicker.js
>
>I have created one and if you don't mind I will add it to bugzilla.
>
>To developers: Maybe it is worth to add sections in FAQ like "how to
>checkout sources from CVS repository", "how to compile it", "how to create
>patch
>file".
>
>And there is ant task for creating patch file.
> <target name="patch" description="Create a patch">
> <cvs command="-q diff -u -N" output="patch.txt"/>
> </target>
>
>Monday, February 2, 2004, 4:22:37 PM, you wrote:
>
>P> Hi,
>
>P> I don't know how to do the patch so I simply send this to the devlist.
>
>P> Thanks,
>P> Norbi
>
> >> >----- Original Message -----
> >> >From: <ny...@shaw.ca>
> >> >To: "Programozas" <pr...@hotmail.com>
> >> >Cc: <ta...@jakarta.apache.org>
> >> >Sent: Thursday, January 29, 2004 5:29 PM
> >> >Subject: RE: DatePicker
> >> >
> >> >
> >> > > Hi,
> >> > >
> >> > > I, too, just ran into the positioning issue in Mozilla and discovered
>P> its
> >> >a bug in the DatePicker javascript
>P> (org.apache.tapestry.form.DatePicker.js).
> >> >I solved it by copying out DatePicker.* from the source into my own
>P> project
> >> >and fixing the javascript.
> >> > >
> >> > > In DatePicker.js in the method
> >> > > Calendar.prototype.show(), lines 550 & 551:
> >> > > the script sets the position of the component by setting
> >> > > <snippet>
> >> > > this._calDiv.style.top = p.y + element.offsetHeight + 1;
> >> > > this._calDiv.style.left = p.x;
> >> > > </snippet>
> >> > >
> >> > > 2 problems with the above lines: First, Mozilla expects them to be
>P> String
> >> >types whereas the above are integer types. Second, these CSS properties
>P> need
> >> >units associated with them such as "px", "pt", "in", "mm", etc. which the
> >> >above lines do not include.
> >> > >
> >> > > TO FIX IT: Add units to the strings:
> >> > > <snippet>
> >> > > this._calDiv.style.top = (p.y + element.offsetHeight + 1) + "px";
> >> > > this._calDiv.style.left = p.x + "px";
> >> > > </snippet>
> >> > >
> >> > > The above fix worked for me and it continues to work in IE as well.
> >> > >
> >> > > Adam.
>
>P> ---------------------------------------------------------------------
>P> To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
>P> For additional commands, e-mail:
>P> tapestry-dev-help@jakarta.apache.org
>
>
>
>--
>Best regards,
> Anatol mailto:anatol_pomazau@epam.com
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org