You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignasi Barrera <na...@apache.org> on 2014/07/01 23:21:07 UTC
Contributing file in all repos
Hi!
We currently have the CONTRIBUTING file [1] in the jclouds-site repo,
and I'd like to add it to the rest of the repos.
Almost every pull request from a new contributor has check style
issues (it's normal), and having a link to the coding guidelines could
help on that.
If no one says the opposite I'll add such a file in all the remaining repos.
I.
[1] https://github.com/blog/1184-contributing-guidelines
Re: Contributing file in all repos
Posted by Andrew Phillips <ap...@qrmedia.com>.
> I've already pushed the exclusion. I think it falls in the same
> category than the README file.
Thanks, Ignasi!
ap
Re: Contributing file in all repos
Posted by Ignasi Barrera <ig...@gmail.com>.
I've already pushed the exclusion. I think it falls in the same
category than the README file.
On 2 July 2014 17:36, Andrew Phillips <ap...@qrmedia.com> wrote:
>> If no one says the opposite I'll add such a file in all the remaining
>> repos.
>
>
> It looks like the new files are causing the RAT plugin to blow up with an
> "unapproved licence" error, e.g.
>
> https://jclouds.ci.cloudbees.com/job/jclouds-labs/506/console
>
> Should we add a licence here or do we add an exception for this?
>
> ap
Re: Contributing file in all repos
Posted by Andrew Phillips <ap...@qrmedia.com>.
> If no one says the opposite I'll add such a file in all the remaining repos.
It looks like the new files are causing the RAT plugin to blow up with
an "unapproved licence" error, e.g.
https://jclouds.ci.cloudbees.com/job/jclouds-labs/506/console
Should we add a licence here or do we add an exception for this?
ap
Re: Contributing file in all repos
Posted by Ignasi Barrera <ig...@gmail.com>.
Not only you! It is a common thing caused by the lack of a link to the
guidelines. Something we must improve! :)
On 1 July 2014 23:43, Dancy, Chris <Ch...@pega.com> wrote:
> He's talking about me!!!
>
> And that's Ok. Now that I know where the link is I'll be less prone to submit ugly code ;)
>
> -----Original Message-----
> From: Ignasi Barrera [mailto:nacx@apache.org]
> Sent: Tuesday, July 01, 2014 5:21 PM
> To: dev@jclouds.apache.org
> Subject: Contributing file in all repos
>
> Hi!
>
> We currently have the CONTRIBUTING file [1] in the jclouds-site repo, and I'd like to add it to the rest of the repos.
>
> Almost every pull request from a new contributor has check style issues (it's normal), and having a link to the coding guidelines could help on that.
>
> If no one says the opposite I'll add such a file in all the remaining repos.
>
> I.
>
>
> [1] https://github.com/blog/1184-contributing-guidelines
RE: Contributing file in all repos
Posted by "Dancy, Chris" <Ch...@pega.com>.
He's talking about me!!!
And that's Ok. Now that I know where the link is I'll be less prone to submit ugly code ;)
-----Original Message-----
From: Ignasi Barrera [mailto:nacx@apache.org]
Sent: Tuesday, July 01, 2014 5:21 PM
To: dev@jclouds.apache.org
Subject: Contributing file in all repos
Hi!
We currently have the CONTRIBUTING file [1] in the jclouds-site repo, and I'd like to add it to the rest of the repos.
Almost every pull request from a new contributor has check style issues (it's normal), and having a link to the coding guidelines could help on that.
If no one says the opposite I'll add such a file in all the remaining repos.
I.
[1] https://github.com/blog/1184-contributing-guidelines
Re: Contributing file in all repos
Posted by Jeremy Daggett <je...@RACKSPACE.COM>.
Thanks Ignasi! Much appreciated.
On 7/1/14, 2:21 PM, "Ignasi Barrera" <na...@apache.org> wrote:
>Hi!
>
>We currently have the CONTRIBUTING file [1] in the jclouds-site repo,
>and I'd like to add it to the rest of the repos.
>
>Almost every pull request from a new contributor has check style
>issues (it's normal), and having a link to the coding guidelines could
>help on that.
>
>If no one says the opposite I'll add such a file in all the remaining
>repos.
>
>I.
>
>
>[1] https://github.com/blog/1184-contributing-guidelines