[GitHub] [spark] maropu edited a comment on issue #25279: [WIP][SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

[GitBox <gi...@apache.org>]

maropu edited a comment on issue #25279: [WIP][SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence
URL: https://github.com/apache/spark/pull/25279#issuecomment-515833431
 
 
   I quickly checked performance numbers on my local;
   ```
   // on Mac (2 GHz Intel Core i5)
   // java version "1.8.0_181"
   // Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
   // Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
   scala> spark.range(30000000L).selectExpr("acosh(id)").write.format("noop").save()
   
   w/Math
   Elapsed time: 0.5992446991111111s
   
   w/StrictMath
   Elapsed time: 1.1835621365555555s
   ```
   As you said in the mail, there are some overheads on x86/64.
   Could you check them on power, @kiszk ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org