You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by to...@apache.org on 2021/08/03 14:19:36 UTC

[skywalking-python] branch master updated: updated kafka protocol for recent changes (#140)

This is an automated email from the ASF dual-hosted git repository.

tompytel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git


The following commit(s) were added to refs/heads/master by this push:
     new bc99949  updated kafka protocol for recent changes (#140)
bc99949 is described below

commit bc999495b187ca5b2b9013da3554d913f380835e
Author: Tomasz Pytel <to...@gmail.com>
AuthorDate: Tue Aug 3 11:19:19 2021 -0300

    updated kafka protocol for recent changes (#140)
---
 skywalking/agent/protocol/kafka.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/skywalking/agent/protocol/kafka.py b/skywalking/agent/protocol/kafka.py
index 6eaabcb..83f1291 100644
--- a/skywalking/agent/protocol/kafka.py
+++ b/skywalking/agent/protocol/kafka.py
@@ -37,9 +37,6 @@ class KafkaProtocol(Protocol):
         self.service_management = KafkaServiceManagementClient()
         self.traces_reporter = KafkaTraceSegmentReportService()
 
-    def connected(self):
-        return True
-
     def heartbeat(self):
         self.service_management.send_heart_beat()
 
@@ -52,7 +49,7 @@ class KafkaProtocol(Protocol):
                     timeout = config.QUEUE_TIMEOUT - int(time() - start)  # type: int
                     if timeout <= 0:  # this is to make sure we exit eventually instead of being fed continuously
                         return
-                    segment = queue.get(block=block)  # type: Segment
+                    segment = queue.get(block=block, timeout=timeout)  # type: Segment
                 except Empty:
                     return