[GitHub] [iceberg] manisin commented on pull request #6674: Add support for special characters in snowflake identifiers for Snowflake Catalog

["manisin (via GitHub)" <gi...@apache.org>]

manisin commented on PR #6674:
URL: https://github.com/apache/iceberg/pull/6674#issuecomment-1407070649

   > the changes mostly LGTM, but it's unclear why we're removing tests with special characters.
   Thanks for the review @nastra ! The test with special characters are removed as I also removed the code for custom handling of the special characters. The special characters have be escaped/quoted correctly according to spark/snowflake documentation by the user and they would be passed through the catalog library to snowflake without any modification.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org