[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

[clockfly <gi...@git.apache.org>]

Github user clockfly commented on the pull request:

    https://github.com/apache/storm/pull/304#issuecomment-61605751
  
    @Sergeant007,
    
    Nice find about the channel = null.
    
    I am a little scared by the complexity of the test code, 
    
    I am +1 if you:
    1. add a comment on top of ```channel = null;```, such as "set it to null to make sure we thrown when reconnection fail'
    2. remove the complex test or replace with clean one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---