You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/13 03:16:00 UTC
[GitHub] [airflow] pingzh opened a new pull request #10310: Use check_output to capture in celery task
pingzh opened a new pull request #10310:
URL: https://github.com/apache/airflow/pull/10310
See: https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10310: Use check_output to capture in celery task
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10310:
URL: https://github.com/apache/airflow/pull/10310#issuecomment-675410036
Thanks @pingzh !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on pull request #10310: Use check_output to capture in celery task
Posted by GitBox <gi...@apache.org>.
pingzh commented on pull request #10310:
URL: https://github.com/apache/airflow/pull/10310#issuecomment-673612262
> Can you provide a context for this change? I would like to know **why** we are changing something, not just **what** has changed.
updated the description to add more context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10310: Use check_output to capture in celery task
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10310:
URL: https://github.com/apache/airflow/pull/10310#issuecomment-673309884
Can you provide a context for this change? I would like to know **why** we are changing something, not just **what** has changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10310: Use check_output to capture in celery task
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10310:
URL: https://github.com/apache/airflow/pull/10310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org