You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/01 01:55:28 UTC

[GitHub] [flink] zoltar9264 opened a new pull request, #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

zoltar9264 opened a new pull request, #21208:
URL: https://github.com/apache/flink/pull/21208

   …ironment#setMaxParallelism()
   
   ## What is the purpose of the change
   
   As the [issue](https://issues.apache.org/jira/browse/FLINK-29822) said, fix wrong description in comments of StreamExecutionEnvironment#setMaxParallelism().
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1297915131

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "34787e18d80186d3e0079619b2d1b23c91a08f1c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "34787e18d80186d3e0079619b2d1b23c91a08f1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 34787e18d80186d3e0079619b2d1b23c91a08f1c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1493814853

   Sorry for not replying in time @pnowojski and forgetting update docs . I have updated the pr, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1477345851

   Hi @pnowojski , can you help me merge this pr ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1482627275

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1298292223

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski merged PR #21208:
URL: https://github.com/apache/flink/pull/21208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1478837392

   Thank you for your reminder @rkhachatryan , I updated the pr, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fredia commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1297943248

   Thanks for the PR, LGTM. In fact, in https://issues.apache.org/jira/browse/FLINK-4380 the description was `0 < maxParallelism <= 2^15`, but https://issues.apache.org/jira/browse/FLINK-5473 changed it, thanks for pointing this out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1483101289

   @zoltar9264, could you regenerate the docs? 
   
   ```
   Documentation is outdated, please regenerate it according to the instructions in flink-docs/README.md
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1427820060

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1467922252

   Hi @rkhachatryan , can you help review this pr, and merge it if it is look good to you ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1494426505

   Thanks, azure is green, merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #21208:
URL: https://github.com/apache/flink/pull/21208#issuecomment-1481453660

   Thanks for reply @pnowojski , I updated the pr with your suggestion, and I also found some other places that need to be corrected. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org