You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "z3d1k (via GitHub)" <gi...@apache.org> on 2023/08/26 00:54:49 UTC

[GitHub] [flink] z3d1k opened a new pull request, #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

z3d1k opened a new pull request, #23297:
URL: https://github.com/apache/flink/pull/23297

   ## What is the purpose of the change
   
   Removing `pip` version check when installing job python dependencies from requirements file.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *flink-python/pyflink/table/tests/test_dependency.py*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: ni
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23297:
URL: https://github.com/apache/flink/pull/23297#issuecomment-1694091501

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "00a39453550ed9c0f2d5bf3912bd0d10a406da12",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "00a39453550ed9c0f2d5bf3912bd0d10a406da12",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 00a39453550ed9c0f2d5bf3912bd0d10a406da12 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaborgsomogyi commented on pull request #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #23297:
URL: https://github.com/apache/flink/pull/23297#issuecomment-1695545731

   The change itself looks good. Where can one find `python` x `pip` compat page?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] z3d1k commented on pull request #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

Posted by "z3d1k (via GitHub)" <gi...@apache.org>.
z3d1k commented on PR #23297:
URL: https://github.com/apache/flink/pull/23297#issuecomment-1695593078

   > The change itself looks good. Where can one find `python` x `pip` compat page?
   
   I was not able to find a dedicated version support page, only mentions in `pip` [release notes](https://pip.pypa.io/en/stable/news/#v18-1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hlteoh37 merged pull request #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 merged PR #23297:
URL: https://github.com/apache/flink/pull/23297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hlteoh37 commented on pull request #23297: [FLINK-32962][python] Remove pip version check on installing dependencies.

Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #23297:
URL: https://github.com/apache/flink/pull/23297#issuecomment-1710397554

   @JingGe @HuangXingBo  Any thoughts on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org