[jira] [Commented] (HADOOP-8633) Interrupted FsShell copies may leave tmp files

["Daryn Sharp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426601#comment-13426601 ] 

Daryn Sharp commented on HADOOP-8633:
-------------------------------------

The {{TargetFileSystem}} is just a shim over a real filesystem that is registering and canceling temp paths for deletion.  The shim simplifies all the code performing the copy and helps ensure the temp files are cancelled and/or deleted immediately.  I originally did what you suggest and I wound up with multiple nested try blocks and conditions that made the code (imho) harder to read, understand, and difficult to test.

It's true that a call to {{System.exit}} won't cleanup the filesystem, but it's only called as the last line in {{main}}.  Calling it in other places would break functionality and be a bug.

(I did manually run a copy with 100 iterations and pounded on control-c and no remnants where left)
                
> Interrupted FsShell copies may leave tmp files
> ----------------------------------------------
>
>                 Key: HADOOP-8633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8633
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-8633.patch
>
>
> Interrupting a copy, ex. via SIGINT, may cause tmp files to not be removed.  If the user is copying large files then the remnants will eat into the user's quota.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira