You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/12 06:52:13 UTC

[GitHub] zhijiangW commented on issue #7549: [FLINK-11403][network] Remove ResultPartitionConsumableNotifier from ResultPartition

zhijiangW commented on issue #7549: [FLINK-11403][network] Remove ResultPartitionConsumableNotifier from ResultPartition
URL: https://github.com/apache/flink/pull/7549#issuecomment-462638845
 
 
   @azagrebin , thanks for your reviews!
   
   I think your suggestion makes sense and is worth trying. We wrap the `ResultPartition` created from `ShuffleService` and other fields related to consumption notification in a separate new class. Then the `RecordWriter` and `Task` only see this new wrapped class avoid of spreading tiny ones anywhere.
   
   I would have a try and re-submit the codes when ready.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services