[jira] [Commented] (DERBY-2031) Convert derbynet/testProtocol.java to JUnit

["Dag H. Wanvik (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219732#comment-13219732 ] 

Dag H. Wanvik commented on DERBY-2031:
--------------------------------------

Looked briefly at the new test. Typo: "adatper". Btw, shouldn't the TestProtocolAdapter#close method be called somewhere in the test lest the socket remain open? Maybe in a finally block in testProtocolSequence? (not a full review yet)
                
> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
>                 Key: DERBY-2031
>                 URL: https://issues.apache.org/jira/browse/DERBY-2031
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Test
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat, derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat, derby-2031-3b-enable_test.diff, derby-2031-4a-close_streams.diff, derby-2031-5a-new_adapter.diff, derby-2031-5a-new_adapter.stat, derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a special-purpose language. The statements are very much like assertions, so it should be fairly easy to convert the test to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail() instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println(). It should also use TestConfiguration to get the host name and port number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira