You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/09 20:43:01 UTC
[GitHub] [druid] suneet-s edited a comment on issue #9441: Improve
OvershadowableManager performance
suneet-s edited a comment on issue #9441: Improve OvershadowableManager performance
URL: https://github.com/apache/druid/pull/9441#issuecomment-596769079
I'm not sure when to override clone and when not to. I think it's meant to be used for deepCopies, so it seems to be a good fit for the function you implemented. Only change that probably matters is in NewestSegmentFirstIterator and tests for the deepCopy methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org