RE: svn commit: r669747 - /stdcxx/branches/4.2.x/include/string.cc

[Eric Lemings <Er...@roguewave.com>]

 

> -----Original Message-----
> From: vitek@apache.org [mailto:vitek@apache.org] 
> Sent: Thursday, June 19, 2008 5:59 PM
> To: commits@stdcxx.apache.org
> Subject: svn commit: r669747 - 
> /stdcxx/branches/4.2.x/include/string.cc
> 
> Author: vitek
> Date: Thu Jun 19 16:58:34 2008
> New Revision: 669747
...
>  
> +#include <rw/_typetraits.h>
>  

Uhgh.  The missing underscore in that header name just really bugs me
for some reason.  Any objections to renaming it as <rw/_type_traits.h>
and updating all code that includes it?  Its an internal header so we
have that privilage and no end-user code should be affected.

Brad.

RE: svn commit: r669747 - /stdcxx/branches/4.2.x/include/string.cc

[Travis Vitek <Tr...@roguewave.com>]

 

Eric Lemings wrote:
> 
>
>> Author: vitek
>> Date: Thu Jun 19 16:58:34 2008
>> New Revision: 669747
>...
>>  
>> +#include <rw/_typetraits.h>
>>  
>
>Uhgh.  The missing underscore in that header name just really bugs me
>for some reason.  Any objections to renaming it as <rw/_type_traits.h>
>and updating all code that includes it?  Its an internal header so we
>have that privilage and no end-user code should be affected.

I don't like it either, but I think it will be best to just leave it
as-is. I'm pretty sure that file is going to go away for 4.3 and later,
so we'd just be making (a little) more work for ourselves in the
meantime.

>Brad.
>