You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2025/07/30 05:45:57 UTC

[PR] chore: update chart list e2e and component tests [superset]

sadpandajoe opened a new pull request, #34393:
URL: https://github.com/apache/superset/pull/34393

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Replaced E2E tests with comprehensive component test coverage
   
     **Tests Updated (94 total):**
   
     - ChartList.test.tsx (20 tests) - Core component behavior, API calls, loading states
     - ChartList.listview.test.tsx (25 tests) - List view functionality, sorting, bulk operations
     - ChartList.cardview.test.tsx (25 tests) - Card view rendering, interactions, view switching
     - ChartList.permissions.test.tsx (24 tests) - Permission-based UI states across user roles
   
     **Infrastructure:**
   
     - ChartList.testHelpers.tsx - Centralized API endpoints, mock setup, and render utilities
     - chartRegistry.test.ts - Chart type registry utilities
   
     **Key Improvements:**
   
     - ✅ Layer separation - Component tests verify API calls, not visual results
     - ✅ Feature flag coverage - Comprehensive testing of tagging, card view defaults
     - ✅ Permission scenarios - Admin, contributor, and viewer role variations
     - ✅ Edge cases - Empty states, null data, loading scenarios
     - ✅ TypeScript compliance - Fixed all type safety issues
     - ✅ Testing principles - Scoped queries, exact assertions, meaningful scenarios
   
   **E2E Tests Removed:**
   
   Eliminated redundant Cypress tests now covered by faster, more reliable component tests following the project's migration away from E2E testing.
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore: update chart list e2e and component tests [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #34393:
URL: https://github.com/apache/superset/pull/34393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore: update chart list e2e and component tests [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #34393:
URL: https://github.com/apache/superset/pull/34393#issuecomment-3134928684

   Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use `/korbit-review`.
   
   
   [](a9bcf712-ee4c-49c2-a9e8-4f5f78488694)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org