You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/10 05:30:29 UTC

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23409


Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................

[client] fix ClangTidy warning in schema.cc

This is to address the following ClangTidy's warning:

  src/kudu/client/schema.cc:173:5: warning: switch has 3 consecutive identical branches [bugprone-branch-clone]
    case kudu::DECIMAL32: return KuduColumnSchema::DECIMAL;
    ^

This changelist doesn't contain any functional modifications.

Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
---
M src/kudu/client/schema.cc
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/23409/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23409 )

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................


Patch Set 1: Verified+1 Code-Review+2

unrelated test failures:
asan: org.apache.kudu.backup.TestKuduBackup
tsan: org.apache.kudu.client.TestKuduClient, kudu-admin-test.5,catalog_manager-test.0


-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 09:18:14 +0000
Gerrit-HasComments: No

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23409 )

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................

[client] fix ClangTidy warning in schema.cc

This is to address the following ClangTidy's warning:

  src/kudu/client/schema.cc:173:5: warning: switch has 3 consecutive identical branches [bugprone-branch-clone]
    case kudu::DECIMAL32: return KuduColumnSchema::DECIMAL;
    ^

This changelist doesn't contain any functional modifications.

Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Reviewed-on: http://gerrit.cloudera.org:8080/23409
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M src/kudu/client/schema.cc
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Marton Greber: Looks good to me, approved; Verified
  Gabriella Lotz: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23409 )

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1784/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 07:22:16 +0000
Gerrit-HasComments: No

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23409 )

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 09:25:02 +0000
Gerrit-HasComments: No

[kudu-CR] [client] fix ClangTidy warning in schema.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23409 )

Change subject: [client] fix ClangTidy warning in schema.cc
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1784/


-- 
To view, visit http://gerrit.cloudera.org:8080/23409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11745a942d7d4c9c2711fcb279e13dec197ce582
Gerrit-Change-Number: 23409
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 05:30:35 +0000
Gerrit-HasComments: No