You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2016/05/22 05:37:57 UTC

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/13243#issuecomment-220815424
  
    The fallback approach doesn't look that simple and clean, can you try split the generated code like we did in `CreateExternalRow`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org