You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/01 20:58:45 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6995: [AIRFLOW-6353]
security - ui - add click jacking defence
tooptoop4 opened a new pull request #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995
- [ X] Description above provides context of the change
- [ X] Commit message contains [\[AIRFLOW-6353\]](https://issues.apache.org/jira/browse/AIRFLOW-6353) or `[AIRFLOW-XXXX]` for document-only changes
- [ X] Unit tests coverage for changes (not needed for documentation changes)
- [ X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X ] Relevant documentation is updated including usage instructions.
- [ X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6995: [AIRFLOW-6353] security
- ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6995:
[AIRFLOW-6353] security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6995: [AIRFLOW-6353]
security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570083149
@mik-laj pls merge (continuation of https://github.com/apache/airflow/pull/6911)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6995: [AIRFLOW-6353]
security - ui - add click jacking defence
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6995: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6995#issuecomment-570085657
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=h1) Report
> Merging [#6995](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6c2a0d42e1dfec68d7aae531b80b5cf8b5fe6114?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
- Coverage 84.85% 84.84% -0.01%
==========================================
Files 679 679
Lines 38536 38541 +5
==========================================
+ Hits 32698 32702 +4
- Misses 5838 5839 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6995/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.02% <80%> (-0.55%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=footer). Last update [6c2a0d4...05d8fc5](https://codecov.io/gh/apache/airflow/pull/6995?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services