You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Thom May <th...@planetarytramp.net> on 2003/07/17 13:07:57 UTC
[PATCH][1.3] Segfault in mod_proxy
Hi folks,
so it seems that ProxyPass operation has been broken since at least 1.3.9;
we're currently firefighting our way through the list of debian bugs and
found http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=57316 - ProxyPass to
ftp urls causes apache to segfault.
The attached patch borrows from proxy_http.c's logic and was written by
Tollef Fog Heen, with hindrance from myself.
If no-one has any objections I'll commit the fix shortly.
Cheers,
-Thom
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by Ben Laurie <be...@algroup.co.uk>.
Thom May wrote:
> Hi folks,
> so it seems that ProxyPass operation has been broken since at least 1.3.9;
> we're currently firefighting our way through the list of debian bugs and
> found http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=57316 - ProxyPass to
> ftp urls causes apache to segfault.
> The attached patch borrows from proxy_http.c's logic and was written by
> Tollef Fog Heen, with hindrance from myself.
> If no-one has any objections I'll commit the fix shortly.
You can't commit EAPI changes to the base.
--
http://www.apache-ssl.org/ben.html http://www.thebunker.net/
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by Joshua Slive <jo...@slive.ca>.
On Thu, 17 Jul 2003, William A. Rowe, Jr. wrote:
> Anyone strongly object to moving on to .29 so we catch this fix?
> Version numbers are cheap - but I think that 1.3'ers enjoy the fact
> that releases are few and far between.
Uhhh... proxypass to ftp urls is a rather obscure feature that is
obviously unused (since it doesn't work). I don't see why this needs to
cause us any grief.
Joshua.
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 07:43 AM 7/17/2003, Jim Jagielski wrote:
>Thom May wrote:
>>
>>
>> Hi folks,
>> so it seems that ProxyPass operation has been broken since at least 1.3.9;
>> we're currently firefighting our way through the list of debian bugs and
>> found http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=57316 - ProxyPass to
>> ftp urls causes apache to segfault.
>> The attached patch borrows from proxy_http.c's logic and was written by
>> Tollef Fog Heen, with hindrance from myself.
>> If no-one has any objections I'll commit the fix shortly.
>> Cheers,
>> -Thom
>>
>
>Hmmm... I wonder if we should hold off on 1.3.28 then. I'm
>leaning towards releasing 1.3.28 as-is, and us placing this
>in patches/ (and of course, being committed to 1.3.29-dev)...
The problem is that for the win32 world, we would also distribute a
patched replacement for this module. That seems unclean, and the
logging issue is fairly minor.
Anyone strongly object to moving on to .29 so we catch this fix?
Version numbers are cheap - but I think that 1.3'ers enjoy the fact
that releases are few and far between.
Bill
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by Thom May <th...@apache.org>.
* Jeff Trawick (trawick@attglobal.net) wrote :
> Thom May wrote:
>
> >--- build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c 2002-04-07
> >20:57:36.000000000 +0200
> >+++ build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c 2003-07-17
> >12:12:34.000000000 +0200
> ...
> >+#ifdef EAPI
> >+ ap_hook_use("ap::mod_proxy::ftp::handler::set_destport",
> >+ AP_HOOK_SIG2(int,ptr),
> >+ AP_HOOK_TOPMOST,
> >+ &destport, r);
> >+#endif /* EAPI */
>
> no "ifdef EAPI" stuff should be present in real Apache for various reasons
>
> (I figure you were going to yank this before committing, but just in
> case...)
>
yes, i was. I should've pulled it before posting, but didn't want to go
messing around hand editting diffs :-)
it's gone from the patch I've applied to my source tree.
Cheers for the review!
-Thom
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by Jeff Trawick <tr...@attglobal.net>.
Thom May wrote:
> --- build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c 2002-04-07 20:57:36.000000000 +0200
> +++ build-tree/apache_1.3.27/src/modules/proxy/proxy_ftp.c 2003-07-17 12:12:34.000000000 +0200
...
> +#ifdef EAPI
> + ap_hook_use("ap::mod_proxy::ftp::handler::set_destport",
> + AP_HOOK_SIG2(int,ptr),
> + AP_HOOK_TOPMOST,
> + &destport, r);
> +#endif /* EAPI */
no "ifdef EAPI" stuff should be present in real Apache for various reasons
(I figure you were going to yank this before committing, but just in
case...)
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by André Malo <nd...@perlig.de>.
* Thom May wrote:
> so it seems that ProxyPass operation has been broken since at least 1.3.9;
> we're currently firefighting our way through the list of debian bugs and
> found http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=57316 - ProxyPass to
> ftp urls causes apache to segfault.
> The attached patch borrows from proxy_http.c's logic and was written by
> Tollef Fog Heen, with hindrance from myself.
> If no-one has any objections I'll commit the fix shortly.
looks good (though untested). +1.
nd
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by David Reid <da...@jetnet.co.uk>.
Let's release 1.3.28...
david
----- Original Message -----
From: "Thom May" <th...@apache.org>
To: <de...@httpd.apache.org>; <ji...@jaguNET.com>
Cc: <tf...@debian.org>
Sent: Thursday, July 17, 2003 1:49 PM
Subject: Re: [PATCH][1.3] Segfault in mod_proxy
> * Jim Jagielski (jim@jaguNET.com) wrote :
> > Thom May wrote:
> > >
> > >
> > > Hi folks,
> >
> > Hmmm... I wonder if we should hold off on 1.3.28 then. I'm
> > leaning towards releasing 1.3.28 as-is, and us placing this
> > in patches/ (and of course, being committed to 1.3.29-dev)...
> >
> > Any objections?
> I don't see that we should hold off 1.3.28, but maybe bring up the
timescale
> for .29 a bit afterwards. So yes, +1.
> (Sorry for bringing this up today, but we litterally only found and fixed
it
> late last night)
> Cheers
> -Thom
>
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by Thom May <th...@apache.org>.
* Jim Jagielski (jim@jaguNET.com) wrote :
> Thom May wrote:
> >
> >
> > Hi folks,
>
> Hmmm... I wonder if we should hold off on 1.3.28 then. I'm
> leaning towards releasing 1.3.28 as-is, and us placing this
> in patches/ (and of course, being committed to 1.3.29-dev)...
>
> Any objections?
I don't see that we should hold off 1.3.28, but maybe bring up the timescale
for .29 a bit afterwards. So yes, +1.
(Sorry for bringing this up today, but we litterally only found and fixed it
late last night)
Cheers
-Thom
Re: [PATCH][1.3] Segfault in mod_proxy
Posted by André Malo <nd...@perlig.de>.
* Jim Jagielski wrote:
> Hmmm... I wonder if we should hold off on 1.3.28 then. I'm
> leaning towards releasing 1.3.28 as-is, and us placing this
> in patches/ (and of course, being committed to 1.3.29-dev)...
+1. It's tagged already and therefore no chance for 1.3.28 get any patches in.
nd