[GitHub] [hudi] nsivabalan commented on a diff in pull request #7974: add validation to HoodieAvroUtils

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #7974:
URL: https://github.com/apache/hudi/pull/7974#discussion_r1120539498


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala:
##########
@@ -103,7 +103,7 @@ object HoodieSparkUtils extends SparkAdapterSupport with SparkVersionsSupport {
         val transform: GenericRecord => GenericRecord =
           if (sameSchema) identity
           else {
-            HoodieAvroUtils.rewriteRecordDeep(_, readerAvroSchema)
+            HoodieAvroUtils.rewriteRecordDeep(_, readerAvroSchema, true)

Review Comment:
   this is in the fast path and would like us to be cautious in doing any per record validations in general. We do have schema validations already. So, trying to wonder if this is really necessary? and why not rely on schema validations and not do per record validations. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org