[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22967: feat(ssh_tunnel): SSH Tunnel Switch extension

["Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #22967:
URL: https://github.com/apache/superset/pull/22967#discussion_r1095247724


##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -1346,14 +1357,33 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
           payload: { login_method: method },
         })
       }
-      removeSSHTunnelConfig={() =>
-        setDB({
-          type: ActionType.removeSSHTunnelConfig,
-        })
-      }
     />
   );
 
+  const renderDefaultSSHTunnelSwitch = () => (

Review Comment:
   Oh! Yeah, that makes sense. Let me work on that and update the PR. Will come back to you when ready 👍 Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org