You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tiles.apache.org by ap...@apache.org on 2009/06/23 17:44:14 UTC
svn commit: r787725 - in /tiles/framework/trunk/tiles-core/src:
main/java/org/apache/tiles/definition/dao/
main/java/org/apache/tiles/definition/pattern/
main/java/org/apache/tiles/util/
test/java/org/apache/tiles/definition/pattern/ test/java/org/apac...
Author: apetrelli
Date: Tue Jun 23 15:44:14 2009
New Revision: 787725
URL: http://svn.apache.org/viewvc?rev=787725&view=rev
Log:
TILES-432
Polished tiles-core.
Modified:
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/dao/ResolvingLocaleUrlDefinitionDAO.java
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolver.java
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java
tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolverTest.java
tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/mock/RepeaterTilesApplicationContextFactory.java
Modified: tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/dao/ResolvingLocaleUrlDefinitionDAO.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/dao/ResolvingLocaleUrlDefinitionDAO.java?rev=787725&r1=787724&r2=787725&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/dao/ResolvingLocaleUrlDefinitionDAO.java (original)
+++ tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/dao/ResolvingLocaleUrlDefinitionDAO.java Tue Jun 23 15:44:14 2009
@@ -16,7 +16,7 @@
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
- * under te License.
+ * under the License.
*/
package org.apache.tiles.definition.dao;
Modified: tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolver.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolver.java?rev=787725&r1=787724&r2=787725&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolver.java (original)
+++ tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolver.java Tue Jun 23 15:44:14 2009
@@ -86,7 +86,7 @@
*/
private void addRegexpMappings(Map<String, Definition> localeDefsMap,
List<PatternMapping> patternMappingList) {
- for (Map.Entry<String, Definition> entry: localeDefsMap.entrySet()) {
+ for (Map.Entry<String, Definition> entry : localeDefsMap.entrySet()) {
String name = entry.getKey();
if (name.startsWith("~")) {
patternMappingList.add(new PatternMapping(name.substring(1),
@@ -101,7 +101,7 @@
* @version $Rev$ $Date$
* @since 2.2.0
*/
- private static class PatternMapping {
+ private static final class PatternMapping {
/**
* The pattern.
@@ -120,7 +120,7 @@
* @param definition The definition.
* @since 2.2.0
*/
- public PatternMapping(String regexp, Definition definition) {
+ private PatternMapping(String regexp, Definition definition) {
pattern = Pattern.compile(regexp);
this.definition = definition;
}
Modified: tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java?rev=787725&r1=787724&r2=787725&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java (original)
+++ tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java Tue Jun 23 15:44:14 2009
@@ -188,7 +188,7 @@
List<String> varsValues = new ArrayList<String>();
boolean retValue = match(varsValues, data, expr);
int i = 0;
- for (String value: varsValues) {
+ for (String value : varsValues) {
map.put(i, value);
i++;
}
Modified: tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolverTest.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolverTest.java?rev=787725&r1=787724&r2=787725&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolverTest.java (original)
+++ tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/definition/pattern/RegexpPatternDefinitionResolverTest.java Tue Jun 23 15:44:14 2009
@@ -53,7 +53,9 @@
}
/**
- * Test method for {@link org.apache.tiles.definition.pattern.RegexpPatternDefinitionResolver#resolveDefinition(java.lang.String, java.lang.Object)}.
+ * Test method for
+ * {@link org.apache.tiles.definition.pattern.RegexpPatternDefinitionResolver
+ * #resolveDefinition(java.lang.String, java.lang.Object)}.
*/
@Test
public void testResolveDefinition() {
Modified: tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/mock/RepeaterTilesApplicationContextFactory.java
URL: http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/mock/RepeaterTilesApplicationContextFactory.java?rev=787725&r1=787724&r2=787725&view=diff
==============================================================================
--- tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/mock/RepeaterTilesApplicationContextFactory.java (original)
+++ tiles/framework/trunk/tiles-core/src/test/java/org/apache/tiles/mock/RepeaterTilesApplicationContextFactory.java Tue Jun 23 15:44:14 2009
@@ -68,11 +68,6 @@
}
}
- /** {@inheritDoc} */
- public void init(Map<String, String> configurationParameters) {
- // Do nothing
- }
-
/**
* Empty application context that does nothing.
*/