[GitHub] [calcite] chunweilei commented on a change in pull request #1710: [CALCITE-2672] Qualifying the common column should not be allowed in Oracle dialect

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1710: [CALCITE-2672] Qualifying the common column should not be allowed in Oracle dialect
URL: https://github.com/apache/calcite/pull/1710#discussion_r362171932
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java
 ##########
 @@ -932,13 +925,6 @@ protected RexLiteral makeLiteral(
       }
       break;
     case TIME:
-      assert o instanceof TimeString;
-      p = type.getPrecision();
-      if (p == RelDataType.PRECISION_NOT_SPECIFIED) {
-        p = 0;
-      }
-      o = ((TimeString) o).round(p);
-      break;
     case TIME_WITH_LOCAL_TIME_ZONE:
 
 Review comment:
   These codes are duplicate with TIME_WITH_LOCAL_TIME_ZONE. So remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services