You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 17:26:00 UTC
[jira] [Commented] (FLINK-9186) Enable dependency convergence for
flink-libraries
[ https://issues.apache.org/jira/browse/FLINK-9186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439755#comment-16439755 ]
ASF GitHub Bot commented on FLINK-9186:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5859
[FLINK-9186][build] Enable dependenvy convergence for flink-libraries
## What is the purpose of the change
This PR enables dependency-convergence for `flink-libraries`. There is only a single violation in `flink-ml` making this a very low-hanging fruit.
## Brief change log
* pin version of scala-xml in flink-ml to 1.0.5 (conflict was 1.0.5 vs 1.0.2)
* remove disabling pom entry from flink-libraries
* remove enabling pom entries from flink-table/flink-sql-client (now redundant)
## Verifying this change
* run `mvn validate` in flink-libraries to check convergence
* run `flink-ml` tests to cover dependency change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9186
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5859.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5859
----
commit 4380fba1c3befc9fe88a7f869ebd81f0e6b8b40f
Author: zentol <ch...@...>
Date: 2018-04-16T17:21:14Z
[FLINK-9186][build] Enable dependenvy convergence for flink-libraries
----
> Enable dependency convergence for flink-libraries
> -------------------------------------------------
>
> Key: FLINK-9186
> URL: https://issues.apache.org/jira/browse/FLINK-9186
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)