You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2014/11/12 12:19:22 UTC

[math] MATH-1167

Repository: commons-math
Updated Branches:
  refs/heads/master 9786ad4de -> 301ad5921


MATH-1167

Use user-specified threshold to allow detection of singular matrix.
[Reported, with fix, by Neil Ireson.]


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/301ad592
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/301ad592
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/301ad592

Branch: refs/heads/master
Commit: 301ad592142079d36f4d33f5309c103c7f4f5dfb
Parents: 9786ad4
Author: Gilles <er...@apache.org>
Authored: Wed Nov 12 12:16:13 2014 +0100
Committer: Gilles <er...@apache.org>
Committed: Wed Nov 12 12:16:13 2014 +0100

----------------------------------------------------------------------
 src/changes/changes.xml                                          | 4 ++++
 .../math3/stat/regression/OLSMultipleLinearRegression.java       | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/301ad592/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index df71204..5377621 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -73,6 +73,10 @@ Users are encouraged to upgrade to this version as this release not
   2. A few methods in the FastMath class are in fact slower that their
   counterpart in either Math or StrictMath (cf. MATH-740 and MATH-901).
 ">
+      <action dev="erans" type="fix" issue="MATH-1167" due-to="Neil Ireson">
+        "o.a.c.m.stat.regression.OLSMultipleLinearRegression": Use threshold
+        when performing "QRDecomposition".
+      </action>
       <action dev="tn" type="fix" issue="MATH-1165" due-to="Pashutan Modaresi">
         "FuzzyKMeansClusterer" has thrown an exception in case one of the data
         points was equal to a cluster center.

http://git-wip-us.apache.org/repos/asf/commons-math/blob/301ad592/src/main/java/org/apache/commons/math3/stat/regression/OLSMultipleLinearRegression.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math3/stat/regression/OLSMultipleLinearRegression.java b/src/main/java/org/apache/commons/math3/stat/regression/OLSMultipleLinearRegression.java
index ba86c5d..8c5dc4c 100644
--- a/src/main/java/org/apache/commons/math3/stat/regression/OLSMultipleLinearRegression.java
+++ b/src/main/java/org/apache/commons/math3/stat/regression/OLSMultipleLinearRegression.java
@@ -233,7 +233,7 @@ public class OLSMultipleLinearRegression extends AbstractMultipleLinearRegressio
     @Override
     protected void newXSampleData(double[][] x) {
         super.newXSampleData(x);
-        qr = new QRDecomposition(getX());
+        qr = new QRDecomposition(getX(), threshold);
     }
 
     /**