You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2009/03/19 03:02:38 UTC
svn commit: r755813 - in
/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime:
FormBodyPart.java HttpMultipart.java content/AbstractContentBody.java
content/FileBody.java content/InputStreamBody.java content/StringBody.java
Author: sebb
Date: Thu Mar 19 02:02:37 2009
New Revision: 755813
URL: http://svn.apache.org/viewvc?rev=755813&view=rev
Log:
Classes aren't thread-safe
Modified:
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/FormBodyPart.java
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/HttpMultipart.java
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/AbstractContentBody.java
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/FileBody.java
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/InputStreamBody.java
httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/FormBodyPart.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/FormBodyPart.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/FormBodyPart.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/FormBodyPart.java Thu Mar 19 02:02:37 2009
@@ -31,6 +31,8 @@
package org.apache.http.entity.mime;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.http.entity.mime.content.ContentBody;
import org.apache.james.mime4j.descriptor.ContentDescriptor;
import org.apache.james.mime4j.message.BodyPart;
@@ -44,6 +46,7 @@
*
* @since 4.0
*/
+@NotThreadSafe // Entity is @NotThreadSafe
public class FormBodyPart extends BodyPart {
private final String name;
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/HttpMultipart.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/HttpMultipart.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/HttpMultipart.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/HttpMultipart.java Thu Mar 19 02:02:37 2009
@@ -39,6 +39,8 @@
import java.nio.charset.Charset;
import java.util.List;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.http.entity.mime.content.ContentBody;
import org.apache.http.protocol.HTTP;
import org.apache.james.mime4j.field.ContentTypeField;
@@ -62,6 +64,7 @@
*
* @since 4.0
*/
+@NotThreadSafe // parent is @NotThreadSafe
public class HttpMultipart extends Multipart {
private static ByteArrayBuffer encode(Charset charset, String string) {
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/AbstractContentBody.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/AbstractContentBody.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/AbstractContentBody.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/AbstractContentBody.java Thu Mar 19 02:02:37 2009
@@ -34,6 +34,8 @@
import java.util.Collections;
import java.util.Map;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.james.mime4j.message.Entity;
import org.apache.james.mime4j.message.SingleBody;
@@ -41,6 +43,7 @@
*
* @since 4.0
*/
+@NotThreadSafe // setParent() also SingleBody and Entity are not T-S
public abstract class AbstractContentBody extends SingleBody implements ContentBody {
private final String mimeType;
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/FileBody.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/FileBody.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/FileBody.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/FileBody.java Thu Mar 19 02:02:37 2009
@@ -37,12 +37,15 @@
import java.io.InputStream;
import java.io.OutputStream;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.http.entity.mime.MIME;
/**
*
* @since 4.0
*/
+@NotThreadSafe // parent is @NotThreadSafe
public class FileBody extends AbstractContentBody {
private final File file;
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/InputStreamBody.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/InputStreamBody.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/InputStreamBody.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/InputStreamBody.java Thu Mar 19 02:02:37 2009
@@ -35,12 +35,15 @@
import java.io.InputStream;
import java.io.OutputStream;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.http.entity.mime.MIME;
/**
*
* @since 4.0
*/
+@NotThreadSafe // parent is @NotThreadSafe
public class InputStreamBody extends AbstractContentBody {
private final InputStream in;
Modified: httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java?rev=755813&r1=755812&r2=755813&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java (original)
+++ httpcomponents/httpclient/trunk/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java Thu Mar 19 02:02:37 2009
@@ -42,12 +42,15 @@
import java.util.HashMap;
import java.util.Map;
+import net.jcip.annotations.NotThreadSafe;
+
import org.apache.http.entity.mime.MIME;
/**
*
* @since 4.0
*/
+@NotThreadSafe // parent is @NotThreadSafe
public class StringBody extends AbstractContentBody {
private final byte[] content;