You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/05/09 20:24:46 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #4880: Test CXF client with a method referencing class with runtime initialization
ppalaga opened a new pull request, #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880
Related #4208 https://github.com/quarkiverse/quarkus-cxf/issues/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on pull request #4880: Test CXF client with a method referencing class with runtime initialization
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on PR #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880#issuecomment-1541619522
Looks great other then found little typing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on pull request #4880: Test CXF client with a method referencing class with runtime initialization
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on PR #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880#issuecomment-1542607410
Ahh, i've haven't sent the review. Doesn't matter, it is harmless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4880: Test CXF client with a method referencing class with runtime initialization
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4880: Test CXF client with a method referencing class with runtime initialization
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880#issuecomment-1540843800
Could you please review, @llowinge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on a diff in pull request #4880: Test CXF client with a method referencing class with runtime initialization
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on code in PR #4880:
URL: https://github.com/apache/camel-quarkus/pull/4880#discussion_r1189564491
##########
integration-test-groups/cxf-soap/cxf-soap-mtom-awt/src/main/java/org/apache/camel/quarkus/component/cxf/soap/mtom/awt/it/CxfSoapMtomAwtResource.java:
##########
@@ -67,13 +67,13 @@ public Response upload(@PathParam("imageName") String imageName, @QueryParam("mt
@GET
public Response download(@PathParam("imageName") String imageName, @QueryParam("mtomEnabled") boolean mtomEnabled)
throws Exception {
- final ImageData image = (ImageData) producerTemplate.requestBodyAndHeader(
+ final java.awt.Image image = producerTemplate.requestBodyAndHeader(
"direct:" + mtomEndpoint(mtomEnabled),
imageName,
OPERATION_NAME,
- "downloadImage", ImageData.class);
+ "downloadImage", java.awt.Image.class);
try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
- ImageIO.write((BufferedImage) image.getData(), "png", baos);
Review Comment:
We don't need `(BufferedImage) ` anymore ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org