You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/10/14 18:20:20 UTC
Review Request 72964: Moved failover timeout validation to stateless
FrameworkInfo validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72964/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10176
https://issues.apache.org/jira/browse/MESOS-10176
Repository: mesos
Description
-------
This turns the validation of the failover timeout in `FrameworkInfo`
into a part of `validation::framework::validate()` that performs
all the other validations that depend on `FrameworkInfo` only.
Diffs
-----
src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188
src/master/validation.cpp 5b1bcb5207aac0553bf9c1a0d89525c835393ccb
Diff: https://reviews.apache.org/r/72964/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72964: Moved failover timeout validation to
stateless FrameworkInfo validation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72964/#review222058
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 14, 2020, 6:20 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72964/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2020, 6:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10176
> https://issues.apache.org/jira/browse/MESOS-10176
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This turns the validation of the failover timeout in `FrameworkInfo`
> into a part of `validation::framework::validate()` that performs
> all the other validations that depend on `FrameworkInfo` only.
>
>
> Diffs
> -----
>
> src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188
> src/master/validation.cpp 5b1bcb5207aac0553bf9c1a0d89525c835393ccb
>
>
> Diff: https://reviews.apache.org/r/72964/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>