You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:56:21 UTC

[GitHub] [iceberg-docs] pvary commented on a diff in pull request #131: Adding vendors page

pvary commented on code in PR #131:
URL: https://github.com/apache/iceberg-docs/pull/131#discussion_r929643714


##########
docs/config.toml:
##########
@@ -36,6 +36,7 @@ home = [ "HTML", "RSS", "SearchIndex" ]
     { name = "Releases", pre = "relative", url = "../../releases", weight = 600 },
     { name = "Blogs", pre = "relative", url = "../../blogs", weight = 998 },
     { name = "Talks", pre = "relative", url = "../../talks", weight = 999 },
+    { name = "Vendors", url = "/vendors", weight = 1000 },

Review Comment:
   nit: maybe stick to the `weight` order - if I understand correctly `weight` defines the order of the menu items, and while it is valid to have them on different order than the point are enumerated this is harder to read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org