[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12645: Refactor federation meta data related classes

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #12645:
URL: https://github.com/apache/shardingsphere/pull/12645#discussion_r714509795



##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/core/metadata/FederationTableMetaData.java
##########
@@ -29,34 +31,38 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 
 /**
  * Federation table meta data.
  */
 @Getter
 public final class FederationTableMetaData {
     
-    private static final RelDataTypeFactory TYPE_FACTORY = new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);   
+    private static final RelDataTypeFactory REL_DATA_TYPE_FACTORY = new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);   

Review comment:
       except the final constant, do we need to make the name upper case even it's a class ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org