You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by Tamás Hanicz <ha...@gmail.com> on 2025/11/17 18:08:18 UTC

[DISCUSS] Move topology specific configs from gateway-site

Hey Folks,

Knox has a few use-cases where topology specific configuration is stored in
the gateway-site.xml. It would be beneficial if these were moved into the
actual topologies for better understanding and readability.

Current use-cases I can think of (there might be more):

   - Topology port mapping
   - Client auth needed exclusion for specific topologies
   - Async-support for specific topologies

These changes could break things in existing environments, especially port
mapping. What are your opinions on this change?

JIRA: http://issues.apache.org/jira/browse/KNOX-3213

Regards, Tamas

Re: [DISCUSS] Move topology specific configs from gateway-site

Posted by Tamás Hanicz <ha...@gmail.com>.
Hey All,

Thanks for the feedback.

These would go into a new section in a topology. We could add a <config>
tag and group them inside. From my point of view it would make sense to
store information about a topology inside its own xml file. I understand
Larry's argument that topology deployment may not be altered at specific
times which could be a huge setback.

Regards, Tamas

Phil Zampino <pz...@apache.org> ezt írta (időpont: 2025. nov. 17., H,
22:41):

> Tamás -
>
> In addition to Larry's points about moving config out of gateway-site into
> topologies, I would like to mention that there are multiple configuration
> items which allow for gateway-wide defaults in gateway-site.xml, which can
> be overridden at the topology level. It's possible that your goal can
> be achieved by following this model as well. Rather than MOVING these
> configurations, perhaps they could be overridden at the topology level.
>
> I'm actually wondering if those specific configurations really make sense
> at the topology level, and I would be interested in understanding
> the motivation better. For instance, topology port mapping seems like a
> gateway-level configuration to me; I am interested to understand why it
> makes more sense as a topology-level configuration.
>
> Where in a topology would such configurations be applied? They're not
> really provider or service configurations, right?
>
> - Phil
>
> On Mon, Nov 17, 2025 at 1:08 PM Tamás Hanicz <ha...@gmail.com> wrote:
>
> > Hey Folks,
> >
> > Knox has a few use-cases where topology specific configuration is stored
> in
> > the gateway-site.xml. It would be beneficial if these were moved into the
> > actual topologies for better understanding and readability.
> >
> > Current use-cases I can think of (there might be more):
> >
> >    - Topology port mapping
> >    - Client auth needed exclusion for specific topologies
> >    - Async-support for specific topologies
> >
> > These changes could break things in existing environments, especially
> port
> > mapping. What are your opinions on this change?
> >
> > JIRA: http://issues.apache.org/jira/browse/KNOX-3213
> >
> > Regards, Tamas
> >
>

Re: [DISCUSS] Move topology specific configs from gateway-site

Posted by Phil Zampino <pz...@apache.org>.
Tamás -

In addition to Larry's points about moving config out of gateway-site into
topologies, I would like to mention that there are multiple configuration
items which allow for gateway-wide defaults in gateway-site.xml, which can
be overridden at the topology level. It's possible that your goal can
be achieved by following this model as well. Rather than MOVING these
configurations, perhaps they could be overridden at the topology level.

I'm actually wondering if those specific configurations really make sense
at the topology level, and I would be interested in understanding
the motivation better. For instance, topology port mapping seems like a
gateway-level configuration to me; I am interested to understand why it
makes more sense as a topology-level configuration.

Where in a topology would such configurations be applied? They're not
really provider or service configurations, right?

- Phil

On Mon, Nov 17, 2025 at 1:08 PM Tamás Hanicz <ha...@gmail.com> wrote:

> Hey Folks,
>
> Knox has a few use-cases where topology specific configuration is stored in
> the gateway-site.xml. It would be beneficial if these were moved into the
> actual topologies for better understanding and readability.
>
> Current use-cases I can think of (there might be more):
>
>    - Topology port mapping
>    - Client auth needed exclusion for specific topologies
>    - Async-support for specific topologies
>
> These changes could break things in existing environments, especially port
> mapping. What are your opinions on this change?
>
> JIRA: http://issues.apache.org/jira/browse/KNOX-3213
>
> Regards, Tamas
>

Re: [DISCUSS] Move topology specific configs from gateway-site

Posted by larry mccay <lm...@apache.org>.
Hi Tamás -

Thanks for the discussion.
I don't think we should MOVE anything from gateway level to topology level.
These decisions were made explicitly.
Breaking existing deployments with a move like this should be avoided.

Adding things that could also be done at the topology level would be fine.

Some things may require machinery setup that is engaged prior to topology
deployment and not able to be altered at that time.
These will reveal themselves as you try to do them though.

thanks!

--larry

On Mon, Nov 17, 2025 at 2:09 PM Sandeep Moré <mo...@gmail.com> wrote:

> Hello Tamas,
> This would be great to have. Another use case would be group mappings
> which are defined in gateway-xml.
>
> Best,
> Sandeep
>
> On Mon, Nov 17, 2025 at 1:08 PM Tamás Hanicz <ha...@gmail.com> wrote:
>
> > Hey Folks,
> >
> > Knox has a few use-cases where topology specific configuration is stored
> in
> > the gateway-site.xml. It would be beneficial if these were moved into the
> > actual topologies for better understanding and readability.
> >
> > Current use-cases I can think of (there might be more):
> >
> >    - Topology port mapping
> >    - Client auth needed exclusion for specific topologies
> >    - Async-support for specific topologies
> >
> > These changes could break things in existing environments, especially
> port
> > mapping. What are your opinions on this change?
> >
> > JIRA: http://issues.apache.org/jira/browse/KNOX-3213
> >
> > Regards, Tamas
> >
>

Re: [DISCUSS] Move topology specific configs from gateway-site

Posted by Sandeep Moré <mo...@gmail.com>.
Hello Tamas,
This would be great to have. Another use case would be group mappings
which are defined in gateway-xml.

Best,
Sandeep

On Mon, Nov 17, 2025 at 1:08 PM Tamás Hanicz <ha...@gmail.com> wrote:

> Hey Folks,
>
> Knox has a few use-cases where topology specific configuration is stored in
> the gateway-site.xml. It would be beneficial if these were moved into the
> actual topologies for better understanding and readability.
>
> Current use-cases I can think of (there might be more):
>
>    - Topology port mapping
>    - Client auth needed exclusion for specific topologies
>    - Async-support for specific topologies
>
> These changes could break things in existing environments, especially port
> mapping. What are your opinions on this change?
>
> JIRA: http://issues.apache.org/jira/browse/KNOX-3213
>
> Regards, Tamas
>