[GitHub] [ignite-3] PakhomovAlexander opened a new pull request, #1907: IGNITE-19191 Optimize integration tests

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander opened a new pull request, #1907:
URL: https://github.com/apache/ignite-3/pull/1907

   ItSslTest and ItGeneratedRestClientTest are optimized by sharing the cluster instance across common tests.
   
   https://issues.apache.org/jira/browse/IGNITE-19191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1907: IGNITE-19191 Optimize integration tests

["valepakh (via GitHub)" <gi...@apache.org>]

valepakh commented on code in PR #1907:
URL: https://github.com/apache/ignite-3/pull/1907#discussion_r1159586207


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/rest/ItGeneratedRestClientTest.java:
##########
@@ -72,31 +72,35 @@
 import org.apache.ignite.rest.client.model.NodeState;
 import org.apache.ignite.rest.client.model.Problem;
 import org.apache.ignite.rest.client.model.UnitStatus;
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInfo;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.TestInstance.Lifecycle;
 import org.junit.jupiter.api.extension.ExtendWith;
 
 /**
  * Test for autogenerated ignite rest client.
  */
 @ExtendWith(WorkDirectoryExtension.class)
 @MicronautTest(rebuildContext = true)
+@TestInstance(Lifecycle.PER_CLASS)
 public class ItGeneratedRestClientTest {
     /** Start network port for test nodes. */
     private static final int BASE_PORT = 3344;
 
     /** Start rest server port. */
     private static final int BASE_REST_PORT = 10300;
 
+    @WorkDirectory
+    private static Path workDir;

Review Comment:
   ```suggestion
       private static Path WORK_DIR;
   ```



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ssl/ItSslTest.java:
##########
@@ -45,34 +45,41 @@
 import org.apache.ignite.internal.app.IgniteImpl;
 import org.apache.ignite.internal.testframework.WorkDirectory;
 import org.intellij.lang.annotations.Language;
-import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInfo;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.TestInstance.Lifecycle;
 
 /** SSL support integration test. */
+@TestInstance(Lifecycle.PER_CLASS)
 public class ItSslTest extends IgniteIntegrationTest {
 
     private static String password;
 
-    private static String trustStorePath;
+    private String trustStorePath;
 
-    private static String keyStorePath;
+    private String keyStorePath;
+
+    private Cluster cluster;
+
+    @WorkDirectory
+    private static Path workDir;

Review Comment:
   ```suggestion
       private static Path WORK_DIR;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] PakhomovAlexander merged pull request #1907: IGNITE-19191 Optimize integration tests

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander merged PR #1907:
URL: https://github.com/apache/ignite-3/pull/1907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org