You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by jk...@apache.org on 2006/08/15 04:12:45 UTC
svn commit: r431487 - in /tapestry/tapestry4/trunk/tapestry-framework/src:
java/org/apache/tapestry/ java/org/apache/tapestry/dojo/html/
java/org/apache/tapestry/form/ java/org/apache/tapestry/html/
java/org/apache/tapestry/link/ js/tapestry/
Author: jkuhnert
Date: Mon Aug 14 19:12:44 2006
New Revision: 431487
URL: http://svn.apache.org/viewvc?rev=431487&view=rev
Log:
For ben. Because we love him dearly.
Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/ComponentEvent.script
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/html/WidgetEvent.script
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/SubmitType.script
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/ElementEvent.script
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/link/DirectLinkWorker.script
tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/ComponentEvent.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/ComponentEvent.script?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/ComponentEvent.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/ComponentEvent.script Mon Aug 14 19:12:44 2006
@@ -17,7 +17,7 @@
<initialization>
<if expression="events">
<foreach expression="events" key="event">
- dojo.event.connect(dojo.byId("${clientId}"), "${event}", function(e) {
+ dojo.event.connectOnce(dojo.byId("${clientId}"), "${event}", function(e) {
var content={beventname:"${event}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${clientId}";
@@ -28,7 +28,7 @@
</if>
<if expression="formEvents">
<foreach expression="formEvents" key="formEvent">
- dojo.event.connect(dojo.byId("${clientId}"), "${formEvent[0]}", function(e){
+ dojo.event.connectOnce(dojo.byId("${clientId}"), "${formEvent[0]}", function(e){
var content={beventname:"${formEvent[0]}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${clientId}";
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/html/WidgetEvent.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/html/WidgetEvent.script?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/html/WidgetEvent.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/dojo/html/WidgetEvent.script Mon Aug 14 19:12:44 2006
@@ -17,7 +17,7 @@
<initialization>
<if expression="events">
<foreach expression="events" key="event">
- dojo.event.connect(dojo.widget.byId("${clientId}"), "${event}", function(e) {
+ dojo.event.connectOnce(dojo.widget.byId("${clientId}"), "${event}", function(e) {
var content={beventname:"${event}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${clientId}";
@@ -28,7 +28,7 @@
</if>
<if expression="formEvents">
<foreach expression="formEvents" key="formEvent">
- dojo.event.connect(dojo.widget.byId("${clientId}"), "${formEvent[0]}", function(e){
+ dojo.event.connectOnce(dojo.widget.byId("${clientId}"), "${formEvent[0]}", function(e){
var content={beventname:"${formEvent[0]}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${clientId}";
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/FormSupportImpl.java?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/FormSupportImpl.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/FormSupportImpl.java Mon Aug 14 19:12:44 2006
@@ -711,7 +711,7 @@
*/
protected IMarkupWriter getHiddenFieldWriter()
{
- if (!_fieldUpdating || !_cycle.getResponseBuilder().isDynamic()) {
+ if (!_cycle.getResponseBuilder().isDynamic() || !_fieldUpdating) {
return _writer;
}
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/SubmitType.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/SubmitType.script?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/SubmitType.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/SubmitType.script Mon Aug 14 19:12:44 2006
@@ -13,7 +13,7 @@
</unique>
</body>
<initialization>
- dojo.event.connect(dojo.byId("${submit.clientId}"), "onclick", function(e){
+ dojo.event.connectOnce(dojo.byId("${submit.clientId}"), "onclick", function(e){
tapestry.form.${type}("${submit.form.clientId}", "${submit.name}");
});
</initialization>
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/ElementEvent.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/ElementEvent.script?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/ElementEvent.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/ElementEvent.script Mon Aug 14 19:12:44 2006
@@ -16,7 +16,7 @@
<initialization>
<if expression="events">
<foreach expression="events" key="event">
- dojo.event.connect(dojo.byId("${target}"), "${event}", function(e) {
+ dojo.event.connectOnce(dojo.byId("${target}"), "${event}", function(e) {
var content={beventname:"${event}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${target}";
@@ -27,7 +27,7 @@
</if>
<if expression="formEvents">
<foreach expression="formEvents" key="formEvent">
- dojo.event.connect(dojo.byId("${target}"), "${formEvent[0]}", function(e){
+ dojo.event.connectOnce(dojo.byId("${target}"), "${formEvent[0]}", function(e){
var content={beventname:"${formEvent[0]}"};
tapestry.event.buildEventProperties(e, content);
if (!content["beventtarget.id"]) content["beventtarget.id"]="${target}";
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/link/DirectLinkWorker.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/link/DirectLinkWorker.script?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/link/DirectLinkWorker.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/link/DirectLinkWorker.script Mon Aug 14 19:12:44 2006
@@ -12,7 +12,7 @@
</unique>
</body>
<initialization>
- dojo.event.connect(dojo.byId("${component.clientId}"), "onclick", function(e){
+ dojo.event.connectOnce(dojo.byId("${component.clientId}"), "onclick", function(e){
dojo.event.browser.stopEvent(e);
var content={beventname:"onClick"};
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js?rev=431487&r1=431486&r2=431487&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js Mon Aug 14 19:12:44 2006
@@ -129,9 +129,9 @@
this.forms[id].json=(typeof json != "undefined") ? json : false;
if (!this.forms[id].async) {
- dojo.event.connect(form, "onsubmit", this, "onFormSubmit");
+ dojo.event.connectOnce(form, "onsubmit", this, "onFormSubmit");
} else {
- dojo.event.connect(form, "onsubmit", function(e) {
+ dojo.event.connectOnce(form, "onsubmit", function(e) {
dojo.event.browser.stopEvent(e);
tapestry.form.submitAsync(form);
});