You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/09/29 23:31:44 UTC
Re: Review Request 52271: GEODE-1938: Big Snapshot File Read
Exception via SnapshotReader API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/
-----------------------------------------------------------
(Updated Sept. 29, 2016, 11:31 p.m.)
Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh Khamesra.
Repository: geode
Description
-------
When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry will fail due code that never allowed for a success case. Even if the type registry was successfull the client would "fail" due to incorrect failure logic.
Diffs
-----
geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java 9476ef4
geode-core/src/test/java/org/apache/geode/internal/cache/snapshot/GFSnapshotDUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/snapshot/TestObject.java PRE-CREATION
Diff: https://reviews.apache.org/r/52271/diff/
Testing (updated)
-------
precheckin - Done
regression - snapshot/snapshot.bt - Done
Thanks,
Udo Kohlmeyer
Re: Review Request 52271: GEODE-1938: Big Snapshot File Read
Exception via SnapshotReader API
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On Oct. 5, 2016, 7:58 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java, line 269
> > <https://reviews.apache.org/r/52271/diff/3/?file=1522497#file1522497line269>
> >
> > you may want to put break statement here..As we aleady got exception
So it fails on the first exception regardless of pool... We would fail on this exception anyway, but only after registering the type with the other pools. I don't mind the registration of the type on the servers even if it were to fail.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/#review151544
-----------------------------------------------------------
On Oct. 5, 2016, 12:36 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52271/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 12:36 a.m.)
>
>
> Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry will fail due code that never allowed for a success case. Even if the type registry was successfull the client would "fail" due to incorrect failure logic.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java 8957e7f
>
> Diff: https://reviews.apache.org/r/52271/diff/
>
>
> Testing
> -------
>
> precheckin - Done
> regression - snapshot/snapshot.bt - Done
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 52271: GEODE-1938: Big Snapshot File Read
Exception via SnapshotReader API
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/#review151544
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java (line 267)
<https://reviews.apache.org/r/52271/#comment219985>
you may want to put break statement here..As we aleady got exception
- Hitesh Khamesra
On Oct. 5, 2016, 12:36 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52271/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 12:36 a.m.)
>
>
> Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry will fail due code that never allowed for a success case. Even if the type registry was successfull the client would "fail" due to incorrect failure logic.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java 8957e7f
>
> Diff: https://reviews.apache.org/r/52271/diff/
>
>
> Testing
> -------
>
> precheckin - Done
> regression - snapshot/snapshot.bt - Done
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 52271: GEODE-1938: Big Snapshot File Read
Exception via SnapshotReader API
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/#review151541
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On Oct. 5, 2016, 12:36 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52271/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 12:36 a.m.)
>
>
> Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry will fail due code that never allowed for a success case. Even if the type registry was successfull the client would "fail" due to incorrect failure logic.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java 8957e7f
>
> Diff: https://reviews.apache.org/r/52271/diff/
>
>
> Testing
> -------
>
> precheckin - Done
> regression - snapshot/snapshot.bt - Done
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 52271: GEODE-1938: Big Snapshot File Read
Exception via SnapshotReader API
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/
-----------------------------------------------------------
(Updated Oct. 5, 2016, 12:36 a.m.)
Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh Khamesra.
Changes
-------
Updated code after testing with a large snapshot file
Repository: geode
Description
-------
When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry will fail due code that never allowed for a success case. Even if the type registry was successfull the client would "fail" due to incorrect failure logic.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java 8957e7f
Diff: https://reviews.apache.org/r/52271/diff/
Testing
-------
precheckin - Done
regression - snapshot/snapshot.bt - Done
Thanks,
Udo Kohlmeyer