[GitHub] [ignite] zstan commented on a diff in pull request #9973: IGNITE-16103 Failed to create index for table "table" with some options

[GitBox <gi...@apache.org>]

zstan commented on code in PR #9973:
URL: https://github.com/apache/ignite/pull/9973#discussion_r850204176


##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/index/H2DynamicTableSelfTest.java:
##########
@@ -619,6 +621,29 @@ public void testQueryParallelism() {
         assertQueryParallelism("QP_OVERWRITE_TEMPLATE", 42);
     }
 
+    /**
+     * Test keywords in table name.
+     * Try to create table with all keywords.
+     */
+    @Test
+    public void testCreateTableWithKeywordName() {
+        int i = 0;
+
+        Set<String> keywords = SqlKeyword.getKeywords();
+
+        for (String entry : keywords

Review Comment:
   fix here + after this issue we can`t call "create table help" and so on ? Is it ok ? + do you really need keywords as public method ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org