You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by sz...@apache.org on 2008/10/21 01:31:55 UTC

svn commit: r706456 - in /hadoop/core/trunk: CHANGES.txt src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java

Author: szetszwo
Date: Mon Oct 20 16:31:55 2008
New Revision: 706456

URL: http://svn.apache.org/viewvc?rev=706456&view=rev
Log:
HADOOP-4369. Use setMetric(...) instead of incrMetric(...) for metrics averages.
  Contributed by Brian Bockelman

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=706456&r1=706455&r2=706456&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Mon Oct 20 16:31:55 2008
@@ -1018,6 +1018,9 @@
     HADOOP-4399. Make fuse-dfs multi-thread access safe.
     (Pete Wyckoff via dhruba)
 
+    HADOOP-4369. Use setMetric(...) instead of incrMetric(...) for metrics
+    averages.  (Brian Bockelman via szetszwo)
+
 Release 0.18.1 - 2008-09-17
 
   IMPROVEMENTS

Modified: hadoop/core/trunk/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java?rev=706456&r1=706455&r2=706456&view=diff
==============================================================================
--- hadoop/core/trunk/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java (original)
+++ hadoop/core/trunk/src/core/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java Mon Oct 20 16:31:55 2008
@@ -134,7 +134,7 @@
     intervalHeartBeat();
     try {
       mr.incrMetric(name + "_num_ops", getPreviousIntervalNumOps());
-      mr.incrMetric(name + "_avg_time", getPreviousIntervalAverageTime());
+      mr.setMetric(name + "_avg_time", getPreviousIntervalAverageTime());
     } catch (Exception e) {
       LOG.info("pushMetric failed for " + name + "\n" +
           StringUtils.stringifyException(e));