[GitHub] [dubbo] guohao commented on a diff in pull request #12575: Triple set resolve fallback enable as default

["guohao (via GitHub)" <gi...@apache.org>]

guohao commented on code in PR #12575:
URL: https://github.com/apache/dubbo/pull/12575#discussion_r1234774257


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java:
##########
@@ -113,9 +114,26 @@ public void afterUnExport() {
 
         invokers.add(invoker);
 
-        pathResolver.add(url.getServiceKey(), invoker);
+        Invoker<?> previous = pathResolver.add(url.getServiceKey(), invoker);

Review Comment:
   这里直接报错是不是更好些



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org