[jira] [Commented] (KAFKA-9409) Increase Immutability of ClusterConfigState

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013818#comment-17013818 ] 

ASF GitHub Bot commented on KAFKA-9409:
---------------------------------------

belugabehr commented on pull request #7942: KAFKA-9409: Increase Immutability of ClusterConfigState
URL: https://github.com/apache/kafka/pull/7942
 
 
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Increase Immutability of ClusterConfigState
> -------------------------------------------
>
>                 Key: KAFKA-9409
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9409
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Priority: Minor
>
> The class claims that it is immutable, but there are some mutable features of this class.
>  
> Increase the immutability of it and add a little cleanup:
>  * Pre-initialize size of ArrayList
>  * Remove superfluous syntax
>  * Use ArrayList instead of LinkedList since the list is created once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)