You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by bi...@apache.org on 2014/04/06 08:46:58 UTC

git commit: CAMEL-5539 Circuit Breaker EIP Fixed broken build

Repository: camel
Updated Branches:
  refs/heads/master 9ed7d85f6 -> 82ef800fd


CAMEL-5539 Circuit Breaker EIP
Fixed broken build


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/82ef800f
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/82ef800f
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/82ef800f

Branch: refs/heads/master
Commit: 82ef800fd47f1bb02f91f907f6040e8b722e2a78
Parents: 9ed7d85
Author: Bilgin Ibryam <bi...@apache.org>
Authored: Sun Apr 6 07:46:38 2014 +0100
Committer: Bilgin Ibryam <bi...@apache.org>
Committed: Sun Apr 6 07:46:38 2014 +0100

----------------------------------------------------------------------
 .../org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/82ef800f/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
----------------------------------------------------------------------
diff --git a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
index 70b9ab8..c2b31c3 100644
--- a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
+++ b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
@@ -25,8 +25,8 @@ import org.apache.camel.Exchange
  */
 case class SLoadBalanceDefinition(override val target: LoadBalanceDefinition)(implicit val builder: RouteBuilder) extends SAbstractDefinition[LoadBalanceDefinition] {
 
-  def circuitbreaker(threshold: Int, halfOpenAfter: Long, exceptions: Class[_]*)
-  = wrap(target.circuitBreaker(threshold, halfOpenAfter, exceptions))
+  def circuitbreaker(threshold: Int, halfOpenAfter: Long, classes: Class[_]*)
+  = wrap(target.circuitBreaker(threshold, halfOpenAfter, classesb: _*))
 
   def failover(classes: Class[_]*) = wrap(target.failover(classes: _*))
 


Re: git commit: CAMEL-5539 Circuit Breaker EIP Fixed broken build

Posted by Gregor Zurowski <gr...@zurowski.org>.
Bilgin and I have further discussed this issue and verified that the
compilations problems are resolved with his proposed typo fix and
building camel-core first.

Therefore, please apply the following PR to fix the current build
problems: https://github.com/apache/camel/pull/131

Thanks,
Gregor

On Mon, Apr 7, 2014 at 12:47 PM, Bilgin Ibryam <bi...@gmail.com> wrote:
> Guys, there is still a small typo in the word: classesb
> There is an extra letter b. Can someone remove that please, I have not
> access to my working machine these days.
>
> TIA,
>
>
>
>
>
> On 7 April 2014 09:45, Claus Ibsen <cl...@gmail.com> wrote:
>
>> Hi
>>
>> Maybe there is still an issue? I get a compile error this morning in
>> camel-scala with latest code.
>>
>>
>> On Sun, Apr 6, 2014 at 8:46 AM,  <bi...@apache.org> wrote:
>> > Repository: camel
>> > Updated Branches:
>> >   refs/heads/master 9ed7d85f6 -> 82ef800fd
>> >
>> >
>> > CAMEL-5539 Circuit Breaker EIP
>> > Fixed broken build
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/camel/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/82ef800f
>> > Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/82ef800f
>> > Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/82ef800f
>> >
>> > Branch: refs/heads/master
>> > Commit: 82ef800fd47f1bb02f91f907f6040e8b722e2a78
>> > Parents: 9ed7d85
>> > Author: Bilgin Ibryam <bi...@apache.org>
>> > Authored: Sun Apr 6 07:46:38 2014 +0100
>> > Committer: Bilgin Ibryam <bi...@apache.org>
>> > Committed: Sun Apr 6 07:46:38 2014 +0100
>> >
>> > ----------------------------------------------------------------------
>> >  .../org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala      | 4
>> ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > ----------------------------------------------------------------------
>> >
>> >
>> >
>> http://git-wip-us.apache.org/repos/asf/camel/blob/82ef800f/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
>> > ----------------------------------------------------------------------
>> > diff --git
>> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
>> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
>> > index 70b9ab8..c2b31c3 100644
>> > ---
>> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
>> > +++
>> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
>> > @@ -25,8 +25,8 @@ import org.apache.camel.Exchange
>> >   */
>> >  case class SLoadBalanceDefinition(override val target:
>> LoadBalanceDefinition)(implicit val builder: RouteBuilder) extends
>> SAbstractDefinition[LoadBalanceDefinition] {
>> >
>> > -  def circuitbreaker(threshold: Int, halfOpenAfter: Long, exceptions:
>> Class[_]*)
>> > -  = wrap(target.circuitBreaker(threshold, halfOpenAfter, exceptions))
>> > +  def circuitbreaker(threshold: Int, halfOpenAfter: Long, classes:
>> Class[_]*)
>> > +  = wrap(target.circuitBreaker(threshold, halfOpenAfter, classesb: _*))
>> >
>> >    def failover(classes: Class[_]*) = wrap(target.failover(classes: _*))
>> >
>> >
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> Email: cibsen@redhat.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>> Make your Camel applications look hawt, try: http://hawt.io
>>
>
>
>
> --
> Bilgin Ibryam
>
> Apache Camel & Apache OFBiz committer
> Blog: ofbizian.com
> Twitter: @bibryam <https://twitter.com/bibryam>
>
> Author of Instant Apache Camel Message Routing
> http://www.amazon.com/dp/1783283475

Re: git commit: CAMEL-5539 Circuit Breaker EIP Fixed broken build

Posted by Gregor Zurowski <gr...@zurowski.org>.
Bilgin and I have further discussed this issue and verified that the
compilations problems are resolved with his proposed typo fix and
building camel-core first.

Therefore, please apply the following PR to fix the current build
problems: https://github.com/apache/camel/pull/131

Thanks,
Gregor


On Mon, Apr 7, 2014 at 12:47 PM, Bilgin Ibryam <bi...@gmail.com> wrote:

> Guys, there is still a small typo in the word: classesb
> There is an extra letter b. Can someone remove that please, I have not
> access to my working machine these days.
>
> TIA,
>
>
>
>
>
> On 7 April 2014 09:45, Claus Ibsen <cl...@gmail.com> wrote:
>
> > Hi
> >
> > Maybe there is still an issue? I get a compile error this morning in
> > camel-scala with latest code.
> >
> >
> > On Sun, Apr 6, 2014 at 8:46 AM,  <bi...@apache.org> wrote:
> > > Repository: camel
> > > Updated Branches:
> > >   refs/heads/master 9ed7d85f6 -> 82ef800fd
> > >
> > >
> > > CAMEL-5539 Circuit Breaker EIP
> > > Fixed broken build
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/82ef800f
> > > Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/82ef800f
> > > Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/82ef800f
> > >
> > > Branch: refs/heads/master
> > > Commit: 82ef800fd47f1bb02f91f907f6040e8b722e2a78
> > > Parents: 9ed7d85
> > > Author: Bilgin Ibryam <bi...@apache.org>
> > > Authored: Sun Apr 6 07:46:38 2014 +0100
> > > Committer: Bilgin Ibryam <bi...@apache.org>
> > > Committed: Sun Apr 6 07:46:38 2014 +0100
> > >
> > > ----------------------------------------------------------------------
> > >  .../org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala      | 4
> > ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/camel/blob/82ef800f/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > > ----------------------------------------------------------------------
> > > diff --git
> >
> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> >
> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > > index 70b9ab8..c2b31c3 100644
> > > ---
> >
> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > > +++
> >
> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > > @@ -25,8 +25,8 @@ import org.apache.camel.Exchange
> > >   */
> > >  case class SLoadBalanceDefinition(override val target:
> > LoadBalanceDefinition)(implicit val builder: RouteBuilder) extends
> > SAbstractDefinition[LoadBalanceDefinition] {
> > >
> > > -  def circuitbreaker(threshold: Int, halfOpenAfter: Long, exceptions:
> > Class[_]*)
> > > -  = wrap(target.circuitBreaker(threshold, halfOpenAfter, exceptions))
> > > +  def circuitbreaker(threshold: Int, halfOpenAfter: Long, classes:
> > Class[_]*)
> > > +  = wrap(target.circuitBreaker(threshold, halfOpenAfter, classesb:
> _*))
> > >
> > >    def failover(classes: Class[_]*) = wrap(target.failover(classes:
> _*))
> > >
> > >
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > Red Hat, Inc.
> > Email: cibsen@redhat.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
> > Make your Camel applications look hawt, try: http://hawt.io
> >
>
>
>
> --
> Bilgin Ibryam
>
> Apache Camel & Apache OFBiz committer
> Blog: ofbizian.com
> Twitter: @bibryam <https://twitter.com/bibryam>
>
> Author of Instant Apache Camel Message Routing
> http://www.amazon.com/dp/1783283475
>

Re: git commit: CAMEL-5539 Circuit Breaker EIP Fixed broken build

Posted by Bilgin Ibryam <bi...@gmail.com>.
Guys, there is still a small typo in the word: classesb
There is an extra letter b. Can someone remove that please, I have not
access to my working machine these days.

TIA,





On 7 April 2014 09:45, Claus Ibsen <cl...@gmail.com> wrote:

> Hi
>
> Maybe there is still an issue? I get a compile error this morning in
> camel-scala with latest code.
>
>
> On Sun, Apr 6, 2014 at 8:46 AM,  <bi...@apache.org> wrote:
> > Repository: camel
> > Updated Branches:
> >   refs/heads/master 9ed7d85f6 -> 82ef800fd
> >
> >
> > CAMEL-5539 Circuit Breaker EIP
> > Fixed broken build
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/82ef800f
> > Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/82ef800f
> > Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/82ef800f
> >
> > Branch: refs/heads/master
> > Commit: 82ef800fd47f1bb02f91f907f6040e8b722e2a78
> > Parents: 9ed7d85
> > Author: Bilgin Ibryam <bi...@apache.org>
> > Authored: Sun Apr 6 07:46:38 2014 +0100
> > Committer: Bilgin Ibryam <bi...@apache.org>
> > Committed: Sun Apr 6 07:46:38 2014 +0100
> >
> > ----------------------------------------------------------------------
> >  .../org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala      | 4
> ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/camel/blob/82ef800f/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > ----------------------------------------------------------------------
> > diff --git
> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > index 70b9ab8..c2b31c3 100644
> > ---
> a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > +++
> b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> > @@ -25,8 +25,8 @@ import org.apache.camel.Exchange
> >   */
> >  case class SLoadBalanceDefinition(override val target:
> LoadBalanceDefinition)(implicit val builder: RouteBuilder) extends
> SAbstractDefinition[LoadBalanceDefinition] {
> >
> > -  def circuitbreaker(threshold: Int, halfOpenAfter: Long, exceptions:
> Class[_]*)
> > -  = wrap(target.circuitBreaker(threshold, halfOpenAfter, exceptions))
> > +  def circuitbreaker(threshold: Int, halfOpenAfter: Long, classes:
> Class[_]*)
> > +  = wrap(target.circuitBreaker(threshold, halfOpenAfter, classesb: _*))
> >
> >    def failover(classes: Class[_]*) = wrap(target.failover(classes: _*))
> >
> >
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> Email: cibsen@redhat.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
> Make your Camel applications look hawt, try: http://hawt.io
>



-- 
Bilgin Ibryam

Apache Camel & Apache OFBiz committer
Blog: ofbizian.com
Twitter: @bibryam <https://twitter.com/bibryam>

Author of Instant Apache Camel Message Routing
http://www.amazon.com/dp/1783283475

Re: git commit: CAMEL-5539 Circuit Breaker EIP Fixed broken build

Posted by Claus Ibsen <cl...@gmail.com>.
Hi

Maybe there is still an issue? I get a compile error this morning in
camel-scala with latest code.


On Sun, Apr 6, 2014 at 8:46 AM,  <bi...@apache.org> wrote:
> Repository: camel
> Updated Branches:
>   refs/heads/master 9ed7d85f6 -> 82ef800fd
>
>
> CAMEL-5539 Circuit Breaker EIP
> Fixed broken build
>
>
> Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/82ef800f
> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/82ef800f
> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/82ef800f
>
> Branch: refs/heads/master
> Commit: 82ef800fd47f1bb02f91f907f6040e8b722e2a78
> Parents: 9ed7d85
> Author: Bilgin Ibryam <bi...@apache.org>
> Authored: Sun Apr 6 07:46:38 2014 +0100
> Committer: Bilgin Ibryam <bi...@apache.org>
> Committed: Sun Apr 6 07:46:38 2014 +0100
>
> ----------------------------------------------------------------------
>  .../org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/camel/blob/82ef800f/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> ----------------------------------------------------------------------
> diff --git a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> index 70b9ab8..c2b31c3 100644
> --- a/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> +++ b/components/camel-scala/src/main/scala/org/apache/camel/scala/dsl/SLoadBalanceDefinition.scala
> @@ -25,8 +25,8 @@ import org.apache.camel.Exchange
>   */
>  case class SLoadBalanceDefinition(override val target: LoadBalanceDefinition)(implicit val builder: RouteBuilder) extends SAbstractDefinition[LoadBalanceDefinition] {
>
> -  def circuitbreaker(threshold: Int, halfOpenAfter: Long, exceptions: Class[_]*)
> -  = wrap(target.circuitBreaker(threshold, halfOpenAfter, exceptions))
> +  def circuitbreaker(threshold: Int, halfOpenAfter: Long, classes: Class[_]*)
> +  = wrap(target.circuitBreaker(threshold, halfOpenAfter, classesb: _*))
>
>    def failover(classes: Class[_]*) = wrap(target.failover(classes: _*))
>
>



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Make your Camel applications look hawt, try: http://hawt.io