[GitHub] [incubator-pagespeed-mod] jmarantz commented on a change in pull request #1929: Data srcset

[GitBox <gi...@apache.org>]

jmarantz commented on a change in pull request #1929: Data srcset
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1929#discussion_r320022317
 
 

 ##########
 File path: net/instaweb/rewriter/url_left_trim_filter.cc
 ##########
 @@ -65,6 +65,7 @@ void UrlLeftTrimFilter::StartElementImpl(HtmlElement* element) {
     resource_tag_scanner::ScanElement(
         element, driver()->options(), &attributes);
     for (int i = 0, n = attributes.size(); i < n; ++i) {
+      if (attributes(i).category == semantic_type::kSrcSetImage) {continue;}
 
 Review comment:
   put the `continue;` on a separate link, which makes it easier to read and debug.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services