You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "sherlock-lin (via GitHub)" <gi...@apache.org> on 2024/03/26 08:25:04 UTC
[PR] [fix][broker][master] PersistentSubscription duplicate implement… [pulsar]
sherlock-lin opened a new pull request, #22359:
URL: https://github.com/apache/pulsar/pull/22359
…ation interface Subscription
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2022238904
Seems like it is:
- https://github.com/apache/pulsar/pull/22344
It's merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2022311328
This isn't a real problem at all. In the Pulsar code base, we currently try to minimize unnecessary changes. This might change after we move to a different type of maintenance strategy, the dev mailing list discussion is https://lists.apache.org/thread/j6qvt45rndnvjypcmqxsfmddqt41bxjv . Refactorings aren't currently mentioned there explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024304577
This is my first pr, if the merge in can give me more confidence, I'll try to avoid mentioning low value pr taking up resources until the technical debt clears up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #22359: [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription
URL: https://github.com/apache/pulsar/pull/22359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024318822
> This is my first pr, if the merge in can give me more confidence, I'll try to avoid mentioning low value pr taking up resources until the technical debt clears up.
Yes, we know. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2023217622
> Just to say that it's better to not create a lot of similar PRs since that would be a lot of changes which don't provide real value. We have a lot of technical debt with more important, but low value areas such as compiler warnings. There's a lot of compiler warnings when compiling Pulsar. We have chosen to ignore them for now. I hope this could change after we have a better maintenance strategy in place.
we can close other patch that not for master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024915435
> > This is my first pr, if the merge in can give me more confidence, I'll try to avoid mentioning low value pr taking up resources until the technical debt clears up.
>
> @sherlock-lin Congrats for the first PR and welcome to join the Pulsar contributors! For the purpose of getting familiar to how PRs are merged and how the Pulsar CI works, this PR was a great way to learn that.
>
> You might notice in future PRs that we have quite a few flaky tests in Pulsar CI and usually there will be multiple flakes and the build will have to be retried multiple times. For this PR, you hadn't yet tried out the ["Personal CI"](https://pulsar.apache.org/contribute/personal-ci/) option for running PR builds in your own fork to get build feedback. That's useful to learn since you can retry failing builds as you like in your own fork and prepare the PR for final review. The guide is missing some details since you will have to enable GitHub Actions in your Pulsar fork. Contributions to the instructions are also welcome if you notice any gaps.
>
> I'm sorry about the criticism about this PR. I got stuck on the detail that this PR isn't a bug fix, but a code cleanup PR and ended up explaining more details why I'm not eager to encourage to do more code cleanup PRs before we have changed the Pulsar maintenance strategy ([#22359 (comment)](https://github.com/apache/pulsar/pull/22359#issuecomment-2022311328)).
>
> We have plenty of valuable contribution opportunies in the Apache Pulsar project. Please join [the Apache Pulsar Slack](https://pulsar.apache.org/community/#section-discussions) and it's #dev channel. When you are looking for contribution opportunies, I'll be happy to suggest valuable opportunies for you and help with any barriers for contributions.
>
> /cc @Technoboy- @codelipenghui
Thanks @lhotari for your patient guidance! in this PR submission I have irregularities thanks for pointing out.
in this process I have learned a lot about contributing code knowledge, I will learn more about submitting pr specification knowledge to improve efficiency!
Also thanks to @Technoboy- @codecov-commenter @liangyuanpeng and other partners for their guidance and help. I'm honored to be able to join Pulsar contributors with everybody to make Pulsar better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2023215652
> This isn't a real problem at all. In the Pulsar code base, we currently try to minimize unnecessary changes. This might change after we move to a different type of maintenance strategy, the dev mailing list discussion is https://lists.apache.org/thread/j6qvt45rndnvjypcmqxsfmddqt41bxjv . Refactorings aren't currently mentioned there explicitly.
I don't agree with you for this patch. This isn't a problem, but from the Java interface definition, it's better to do like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2023306788
> I don't agree with you for this patch. This isn't a problem, but from the Java interface definition, it's better to do like this.
@Technoboy- what is it that you don't agree? I agree that it is "better". When something is "better", this implies that it produces some benefit. In this case, what is it that it makes better? The question is then whether this benefit is relevant when we are considering how Pulsar is currently maintained. I've provided my opinion about formatting changes in this mailing list post: https://lists.apache.org/thread/lo15cdzsl740dwgcqwpsl9oy9qb13onv . After we settle on a maintenance strategy that reduces merge conflicts for maintaining the LTS branch, we have more freedom to do refactorings which we are currently avoiding because of the merge conflicts. Merge conflicts caused by unnecessary changes are the main reason for my resistance. That could be resolved with an improved maintenance strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2022203647
> /pulsarbot rerun-failure-checks
What should I do please, I haven't changed the file that failed detection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024335935
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 73.63%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fcde506`)](https://app.codecov.io/gh/apache/pulsar/pull/22359?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 99 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/22359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #22359 +/- ##
============================================
+ Coverage 73.57% 73.63% +0.06%
+ Complexity 32624 32125 -499
============================================
Files 1877 1879 +2
Lines 139502 140277 +775
Branches 15299 15571 +272
============================================
+ Hits 102638 103299 +661
- Misses 28908 28967 +59
- Partials 7956 8011 +55
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.28% <ø> (+2.69%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/22359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.62% <ø> (+0.30%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.88% <ø> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/22359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rvice/nonpersistent/NonPersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/22359?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fnonpersistent%2FNonPersistentSubscription.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `53.27% <ø> (ø)` | |
| [...ker/service/persistent/PersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/22359?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2Fpersistent%2FPersistentSubscription.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `76.72% <ø> (+0.03%)` | :arrow_up: |
... and [150 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024475158
> This is my first pr, if the merge in can give me more confidence, I'll try to avoid mentioning low value pr taking up resources until the technical debt clears up.
@sherlock-lin Congrats for the first PR and welcome to join the Pulsar contributors! For the purpose of getting familiar to how PRs are merged and how the Pulsar CI works, this PR was a great way to learn that.
You might notice in future PRs that we have quite a few flaky tests in Pulsar CI and usually there will be multiple flakes and the build will have to be retried multiple times. For this PR, you hadn't yet tried out the ["Personal CI"](https://pulsar.apache.org/contribute/personal-ci/) option for running PR builds in your own fork to get build feedback. That's useful to learn since you can retry failing builds as you like in your own fork and prepare the PR for final review. The guide is missing some details since you will have to enable GitHub Actions in your Pulsar fork. Contributions to the instructions are also welcome if you notice any gaps.
I'm sorry about the criticism about this PR. I got stuck on the detail that this PR isn't a bug fix, but a code cleanup PR and ended up explaining more details why I'm not eager to encourage to do more code cleanup PRs before we have changed the Pulsar maintenance strategy (https://github.com/apache/pulsar/pull/22359#issuecomment-2022311328).
We have plenty of valuable contribution opportunies in the Apache Pulsar project. Please join [the Apache Pulsar Slack](https://pulsar.apache.org/community/#section-discussions) and it's #dev channel. When you are looking for contribution opportunies, I'll be happy to suggest valuable opportunies for you and help with any barriers for contributions.
/cc @Technoboy- @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2024299728
> > I don't agree with you for this patch. This isn't a problem, but from the Java interface definition, it's better to do like this.
>
> @Technoboy- what is it that you don't agree? I agree that it is "better". When something is "better", this implies that it produces some benefit. In this case, what is it that it makes better? The question is then whether this benefit is relevant when we are considering how Pulsar is currently maintained. I've provided my opinion about formatting changes in this mailing list post: https://lists.apache.org/thread/lo15cdzsl740dwgcqwpsl9oy9qb13onv . After we settle on a maintenance strategy that reduces merge conflicts for maintaining the LTS branch, we have more freedom to do refactorings which we are currently avoiding because of the merge conflicts. Merge conflicts caused by unnecessary changes are the main reason for my resistance. That could be resolved with an improved maintenance strategy.
#22295 don't have any better, but just no `anything harmful.` And you merge it. From my side, you merge the pr you create, but others give some suggestion and leave the pr there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2022326119
Just to say that it's better to not create a lot of similar PRs since that would be a lot of changes which don't provide real value. We have a lot of technical debt with more important, but low value areas such as compiler warnings. There's a lot of compiler warnings when compiling Pulsar. We have chosen to ignore them for now. I hope this could change after we have a better maintenance strategy in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #22359:
URL: https://github.com/apache/pulsar/pull/22359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix PersistentSubscription duplicate implementation interface Subscription [pulsar]
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng commented on PR #22359:
URL: https://github.com/apache/pulsar/pull/22359#issuecomment-2022121539
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org