You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 12:55:55 UTC
[GitHub] [arrow] assignUser commented on a diff in pull request #14731: ARROW-18380: [Dev] Update dev_pr GitHub workflows to accept both GitHub issues and JIRA
assignUser commented on code in PR #14731:
URL: https://github.com/apache/arrow/pull/14731#discussion_r1032422763
##########
.github/workflows/dev_pr/issue_check.js:
##########
@@ -78,11 +78,42 @@ async function commentNotStartedTicket(github, context, pullRequestNumber) {
}
}
+async function verifyGitHubIssue(github, context, pullRequestNumber, issueID) {
+ const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
+ if (issueInfo) {
+ if (!issueInfo.assignees.length) {
+ await github.issues.createComment({
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ issue_number: pullRequestNumber,
+ body: ":warning: GitHub issue #" + issueID + " **has not been assigned in GitHub**, please assign the ticket."
+ })
+ }
+ if(!issueInfo.labels.length) {
+ await github.issues.createComment({
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ issue_number: pullRequestNumber,
+ body: ":warning: GitHub issue #" + issueID + " **has no labels in GitHub**, please add labels for components."
+ })
+ }
+ } else {
+ await github.issues.createComment({
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ issue_number: pullRequestNumber,
+ body: ":warning: GitHub issue #" + issueID + " could not be retrieved."
Review Comment:
❌ ?
##########
.github/workflows/dev_pr/issue_check.js:
##########
@@ -78,11 +78,42 @@ async function commentNotStartedTicket(github, context, pullRequestNumber) {
}
}
+async function verifyGitHubIssue(github, context, pullRequestNumber, issueID) {
+ const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
+ if (issueInfo) {
+ if (!issueInfo.assignees.length) {
+ await github.issues.createComment({
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ issue_number: pullRequestNumber,
+ body: ":warning: GitHub issue #" + issueID + " **has not been assigned in GitHub**, please assign the ticket."
Review Comment:
Should we just assign it to the person opening the PR? Unlike JIRA issues gh issues can have more than one assignee (up to 10), so that should not require any fancy checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org