[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3623: [#3607] fix idle time out and keep alive timeout not properly set pro…

["liubao68 (via GitHub)" <gi...@apache.org>]

liubao68 commented on code in PR #3623:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3623#discussion_r1097394963


##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java:
##########
@@ -77,7 +77,7 @@ private static HttpClientOptions createHttpClientOptions() {
     HttpClientOptions httpClientOptions = new HttpClientOptions();
     httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
         .setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
-        .setKeepAliveTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+        .setKeepAliveTimeout(TransportClientConfig.getHttp1ConnectionKeepAliveTimeoutInSeconds())

Review Comment:
   This change should create PR to master/2.8.x/1.3.x



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org