You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/12 00:38:41 UTC
Review Request 55438: Fixed flakiness in
SlaveRecoveryTest.RegisterDisconnectedSlave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55438/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6911
https://issues.apache.org/jira/browse/MESOS-6911
Repository: mesos
Description
-------
Fixed flakiness in SlaveRecoveryTest.RegisterDisconnectedSlave.
Diffs
-----
src/tests/slave_recovery_tests.cpp 9323cbb74dd555fe6c44af1ef6da70e0c2d76dcb
Diff: https://reviews.apache.org/r/55438/diff/
Testing
-------
`make check`
Ran ~5000 test iterations on a slow VM that previously exhibited flakiness for this test.
Thanks,
Neil Conway
Re: Review Request 55438: Fixed flakiness in
SlaveRecoveryTest.RegisterDisconnectedSlave.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55438/#review161348
-----------------------------------------------------------
Bad patch!
Reviews applied: [55438, 55437]
Failed command: python support/apply-reviews.py -n -r 55437
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 349, in <module>
reviewboard()
File "support/apply-reviews.py", line 328, in reviewboard
apply_review()
File "support/apply-reviews.py", line 121, in apply_review
fetch_patch()
File "support/apply-reviews.py", line 150, in fetch_patch
r = urllib2.urlopen(patch_url(), context=ssl_create_default_context())
File "support/apply-reviews.py", line 131, in ssl_create_default_context
context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
AttributeError: 'module' object has no attribute 'SSLContext'
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "support/apply-reviews.py", line 119, in <lambda>
atexit.register(lambda: os.remove('%s.patch' % patch_id()))
OSError: [Errno 2] No such file or directory: '55437.patch'
Error in sys.exitfunc:
Traceback (most recent call last):
File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "support/apply-reviews.py", line 119, in <lambda>
atexit.register(lambda: os.remove('%s.patch' % patch_id()))
OSError: [Errno 2] No such file or directory: '55437.patch'
Full log: https://builds.apache.org/job/Mesos-Reviewbot/16689/console
- Mesos ReviewBot
On Jan. 12, 2017, 12:38 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55438/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 12:38 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6911
> https://issues.apache.org/jira/browse/MESOS-6911
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in SlaveRecoveryTest.RegisterDisconnectedSlave.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 9323cbb74dd555fe6c44af1ef6da70e0c2d76dcb
>
> Diff: https://reviews.apache.org/r/55438/diff/
>
>
> Testing
> -------
>
> `make check`
>
> Ran ~5000 test iterations on a slow VM that previously exhibited flakiness for this test.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55438: Fixed flakiness in
SlaveRecoveryTest.RegisterDisconnectedSlave.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55438/#review161859
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 12, 2017, 12:38 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55438/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 12:38 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6911
> https://issues.apache.org/jira/browse/MESOS-6911
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in SlaveRecoveryTest.RegisterDisconnectedSlave.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 9323cbb74dd555fe6c44af1ef6da70e0c2d76dcb
>
> Diff: https://reviews.apache.org/r/55438/diff/
>
>
> Testing
> -------
>
> `make check`
>
> Ran ~5000 test iterations on a slow VM that previously exhibited flakiness for this test.
>
>
> Thanks,
>
> Neil Conway
>
>