[GitHub] rawlinp commented on a change in pull request #3274: Fix Traffic Ops CDN DNSSEC generation when no delivery services exist

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3274: Fix Traffic Ops CDN DNSSEC generation when no delivery services exist
URL: https://github.com/apache/trafficcontrol/pull/3274#discussion_r252782407
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cdn/dnssec.go
 ##########
 @@ -245,7 +257,7 @@ type CDNDS struct {
 }
 
 // getCDNDeliveryServices returns basic data for the delivery services on the given CDN, as well as the CDN name, or any error.
-func getCDNDeliveryServices(tx *sql.Tx, cdn string) ([]CDNDS, string, error) {
+func GetCDNDeliveryServices(tx *sql.Tx, cdn string) ([]CDNDS, error) {
 	q := `
 SELECT ds.xml_id, ds.protocol, t.name as type, ds.routing_name, cdn.domain_name as cdn_domain
 
 Review comment:
   The `cdn.domain_name as cdn_domain` should be removed from the query if it's not being scanned out from the result, right?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services