[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7177: Spark 3.3: Use ProcedureInput in AncestorsOfProcedure

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #7177:
URL: https://github.com/apache/iceberg/pull/7177#discussion_r1146559185


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -153,7 +166,7 @@ private <K, V> Map<K, V> map(
     return convertedMap;
   }
 
-  public Identifier ident(ProcedureParameter param) {
+  public Identifier asIdent(ProcedureParameter param) {

Review Comment:
   I'm not sure we actually want to use `asIdent` here, I think it makes sense for obtaining the other types but ident by  itself should be sufficient



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org