You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 15:11:36 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7076: Remove duplicate calls and optimize compilation speed

gustavonihei commented on code in PR #7076:
URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r1003437939


##########
drivers/segger/Make.defs:
##########
@@ -27,11 +27,11 @@ ifeq ($(CONFIG_SEGGER_RTT),y)
   CFLAGS += -Wno-shadow -Wno-array-bounds
 
   ifneq ($(CONFIG_SEGGER_RTT_SECTION),"")
-    CFLAGS += ${shell $(DEFINE) "$(CC)" SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
+    ${call DEFINE, CFLAGS, SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}

Review Comment:
   ```suggestion
       ${call DEFINE,CFLAGS,SEGGER_RTT_SECTION=CONFIG_SEGGER_RTT_SECTION}
   ```
   The `call` function arguments should not be preceded with whitespaces to prevent unwanted effects:
   See the "final caution" at the end of the documentation at https://www.gnu.org/software/make/manual/html_node/Call-Function.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org