You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bo...@apache.org on 2002/11/18 19:36:05 UTC
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteRequest.java
bobh 2002/11/18 10:36:05
Modified: coyote/src/java/org/apache/coyote/tomcat5 CoyoteRequest.java
Log:
- Servlet 2.4, section 10.6 talks about how to handle "Listener Exceptions."
It says a listener exception should cause the error page handling stuff
to be triggered. This change does that.
Revision Changes Path
1.7 +8 -6 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteRequest.java
Index: CoyoteRequest.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteRequest.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- CoyoteRequest.java 18 Oct 2002 21:37:08 -0000 1.6
+++ CoyoteRequest.java 18 Nov 2002 18:36:05 -0000 1.7
@@ -1167,8 +1167,9 @@
try {
listener.attributeRemoved(event);
} catch (Throwable t) {
- // FIXME - should we do anything besides log these?
log(sm.getString("coyoteRequest.attributeEvent"), t);
+ // Error valve will pick this execption up and display it to user
+ attributes.put( Globals.EXCEPTION_ATTR, t );
}
}
}
@@ -1235,8 +1236,9 @@
listener.attributeAdded(event);
}
} catch (Throwable t) {
- // FIXME - should we do anything besides log these?
log(sm.getString("coyoteRequest.attributeEvent"), t);
+ // Error valve will pick this execption up and display it to user
+ attributes.put( Globals.EXCEPTION_ATTR, t );
}
}
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>