[jira] [Commented] (YARN-5221) Expose UpdateResourceRequest API to allow AM to request for change in container properties

["Wangda Tan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386567#comment-15386567 ] 

Wangda Tan commented on YARN-5221:
----------------------------------

Thanks for update [~asuresh].

Patch generally looks good, my only comment is validateIncreaseDecreaseRequest dropped some previous diagnostic messages such as:

{code}
260	            + (increase ? "increase" : "decrease") + " request"		
261	            + ", requested virtual cores < 0"		
262	            + ", or requested virtual cores > max configured"		
263	            + ", requestedVirtualCores="		
264	            + request.getCapability().getVirtualCores() + ", maxVirtualCores="		
265	            + maximumAllocation.getVirtualCores());
{code}

It's better to add them back to easier identify problems.

And also, if this patch goes in, could you also update example of YARN-4175? Since YARN-4175 is the only public example to show how to use increase/decrease feature.

And would like to get more reviews from other committers. ([~kasha]).

Thanks,

> Expose UpdateResourceRequest API to allow AM to request for change in container properties
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-5221
>                 URL: https://issues.apache.org/jira/browse/YARN-5221
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5221.001.patch, YARN-5221.002.patch, YARN-5221.003.patch, YARN-5221.004.patch, YARN-5221.005.patch, YARN-5221.006.patch, YARN-5221.007.patch
>
>
> YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease of Container Resources after initial allocation.
> YARN-5085 proposes to allow an AM to request for a change of Container ExecutionType.
> This JIRA proposes to unify both of the above into an Update Container API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org